Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 299833008: Move AcceptWithResponder() out of the MessageReceiver interface. (Closed)

Created:
6 years, 7 months ago by yzshen1
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Move AcceptWithResponder() out of the MessageReceiver interface. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272831

Patch Set 1 #

Patch Set 2 : rename to MessageReceiverWithResponder as discussed #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -70 lines) Patch
M mojo/public/cpp/bindings/lib/connector.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/message_filter.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 1 4 chunks +4 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M mojo/public/cpp/bindings/message.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/message_filter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/no_interface.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/router_unittest.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 2 chunks +1 line, -7 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? I think this results in more clear ...
6 years, 7 months ago (2014-05-22 19:58:23 UTC) #1
darin (slow to review)
This is a great patch! We just need a better name ;-)
6 years, 7 months ago (2014-05-22 23:55:39 UTC) #2
yzshen1
On 2014/05/22 23:55:39, darin wrote: > This is a great patch! We just need a ...
6 years, 7 months ago (2014-05-22 23:56:55 UTC) #3
qsr
I was thinking about doing something like this on the java implementation. Good to know ...
6 years, 7 months ago (2014-05-23 09:10:09 UTC) #4
yzshen1
Darin: Would you please take another look? Thanks! On 2014/05/23 09:10:09, qsr wrote: > I ...
6 years, 7 months ago (2014-05-23 16:34:49 UTC) #5
darin (slow to review)
LGTM
6 years, 7 months ago (2014-05-24 04:15:07 UTC) #6
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 7 months ago (2014-05-24 04:37:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/299833008/10001
6 years, 7 months ago (2014-05-24 04:38:08 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 06:26:12 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 06:31:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69644)
6 years, 7 months ago (2014-05-24 06:31:22 UTC) #11
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 7 months ago (2014-05-26 07:11:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/299833008/30001
6 years, 7 months ago (2014-05-26 07:12:38 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 15:57:10 UTC) #14
Message was sent while issue was closed.
Change committed as 272831

Powered by Google App Engine
This is Rietveld 408576698