Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 299813002: Revert "Fix Heap::IsHeapIterable." (again) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-profiler.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "v8.h" 5 #include "v8.h"
6 6
7 #include "heap-snapshot-generator-inl.h" 7 #include "heap-snapshot-generator-inl.h"
8 8
9 #include "allocation-tracker.h" 9 #include "allocation-tracker.h"
10 #include "code-stubs.h" 10 #include "code-stubs.h"
(...skipping 2551 matching lines...) Expand 10 before | Expand all | Expand 10 after
2562 Heap* debug_heap = heap_; 2562 Heap* debug_heap = heap_;
2563 CHECK(!debug_heap->old_data_space()->was_swept_conservatively()); 2563 CHECK(!debug_heap->old_data_space()->was_swept_conservatively());
2564 CHECK(!debug_heap->old_pointer_space()->was_swept_conservatively()); 2564 CHECK(!debug_heap->old_pointer_space()->was_swept_conservatively());
2565 CHECK(!debug_heap->code_space()->was_swept_conservatively()); 2565 CHECK(!debug_heap->code_space()->was_swept_conservatively());
2566 CHECK(!debug_heap->cell_space()->was_swept_conservatively()); 2566 CHECK(!debug_heap->cell_space()->was_swept_conservatively());
2567 CHECK(!debug_heap->property_cell_space()-> 2567 CHECK(!debug_heap->property_cell_space()->
2568 was_swept_conservatively()); 2568 was_swept_conservatively());
2569 CHECK(!debug_heap->map_space()->was_swept_conservatively()); 2569 CHECK(!debug_heap->map_space()->was_swept_conservatively());
2570 #endif 2570 #endif
2571 2571
2572 // The following code uses heap iterators, so we want the heap to be
2573 // stable. It should follow TagGlobalObjects as that can allocate.
2574 DisallowHeapAllocation no_alloc;
2575
2572 #ifdef VERIFY_HEAP 2576 #ifdef VERIFY_HEAP
2573 debug_heap->Verify(); 2577 debug_heap->Verify();
2574 #endif 2578 #endif
2575 2579
2576 SetProgressTotal(2); // 2 passes. 2580 SetProgressTotal(2); // 2 passes.
2577 2581
2578 #ifdef VERIFY_HEAP 2582 #ifdef VERIFY_HEAP
2579 debug_heap->Verify(); 2583 debug_heap->Verify();
2580 #endif 2584 #endif
2581 2585
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
3145 writer_->AddString("\"<dummy>\""); 3149 writer_->AddString("\"<dummy>\"");
3146 for (int i = 1; i < sorted_strings.length(); ++i) { 3150 for (int i = 1; i < sorted_strings.length(); ++i) {
3147 writer_->AddCharacter(','); 3151 writer_->AddCharacter(',');
3148 SerializeString(sorted_strings[i]); 3152 SerializeString(sorted_strings[i]);
3149 if (writer_->aborted()) return; 3153 if (writer_->aborted()) return;
3150 } 3154 }
3151 } 3155 }
3152 3156
3153 3157
3154 } } // namespace v8::internal 3158 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-profiler.cc ('k') | src/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698