Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 299803003: Add isPausedWorker command to Runtime and use it to auto attach DevTools to ServiceWorker. (Closed)

Created:
6 years, 7 months ago by horo
Modified:
6 years, 7 months ago
Reviewers:
sergeyv, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add isPausedWorker command to Runtime and use it to auto attach DevTools to ServiceWorker. BUG=358657 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174735

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rename isPausedWorker to into isRunRequired #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M Source/core/inspector/InspectorRuntimeAgent.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/inspector/WorkerRuntimeAgent.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/WorkerRuntimeAgent.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 1 chunk +25 lines, -4 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
horo
pfeldman@ Could you please review this?
6 years, 7 months ago (2014-05-21 09:06:07 UTC) #1
yurys
How can it happen that isPausedWorker is true at the moment we attach to a ...
6 years, 7 months ago (2014-05-21 10:23:48 UTC) #2
horo
On 2014/05/21 10:23:48, yurys wrote: > How can it happen that isPausedWorker is true at ...
6 years, 7 months ago (2014-05-21 14:21:24 UTC) #3
yurys
LGTM. Sorry for the delay. We discussed this with Pavel and it seems that reporting ...
6 years, 7 months ago (2014-05-23 09:09:13 UTC) #4
horo
https://codereview.chromium.org/299803003/diff/20001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/299803003/diff/20001/Source/devtools/protocol.json#newcode827 Source/devtools/protocol.json:827: "name": "isPausedWorker", On 2014/05/23 09:09:14, yurys wrote: > Let's ...
6 years, 7 months ago (2014-05-23 10:03:20 UTC) #5
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-23 15:36:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/299803003/40001
6 years, 7 months ago (2014-05-23 15:36:40 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 17:11:36 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 18:33:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/8940)
6 years, 7 months ago (2014-05-23 18:33:18 UTC) #10
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-24 00:04:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/299803003/40001
6 years, 7 months ago (2014-05-24 00:04:43 UTC) #12
commit-bot: I haz the power
Change committed as 174735
6 years, 7 months ago (2014-05-24 00:54:56 UTC) #13
horo
6 years, 7 months ago (2014-05-24 02:02:17 UTC) #14
Message was sent while issue was closed.
On 2014/05/24 00:54:56, I haz the power (commit-bot) wrote:
> Change committed as 174735

Oh, I forgot to change the description...

Powered by Google App Engine
This is Rietveld 408576698