Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2998023002: [pinpoint] Provide full Change details in AsDict(). (Closed)

Created:
3 years, 4 months ago by dtu
Modified:
3 years, 4 months ago
Reviewers:
perezju, shatch, sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[pinpoint] Provide full Change details in AsDict(). The Change string is not sufficient for the UI to do things like provide links to the commits or look up the commit subject and author. In addition, the truncated git hash is not guaranteed to be unique. BUG=catapult:#3334 Review-Url: https://codereview.chromium.org/2998023002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e1241eb99c0a0e68e678878b879e1c1cd10b3352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M dashboard/dashboard/pinpoint/models/change.py View 3 chunks +13 lines, -0 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/change_test.py View 3 chunks +34 lines, -0 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/job.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
dtu
3 years, 4 months ago (2017-08-17 22:23:07 UTC) #3
sullivan
lgtm
3 years, 4 months ago (2017-08-17 22:34:14 UTC) #4
shatch
lgtm
3 years, 4 months ago (2017-08-18 00:57:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2998023002/1
3 years, 4 months ago (2017-08-18 04:04:55 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 04:32:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698