Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2998003002: Revert "fix #30462, update function_type tests to understand covariant generics" (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly
Modified:
3 years, 4 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "fix #30462, update function_type tests to understand covariant generics" This reverts commit 2ea6a5dd5cd389db00479ea41c74241ff8336ea4. Committed: https://github.com/dart-lang/sdk/commit/11f4152712a4f5a183fb6f4bfe5b7e2e7a400a8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -348 lines) Patch
M tests/language_2/function_type/function_type0_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type10_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type12_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language_2/function_type/function_type13_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type14_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type15_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type16_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type17_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type18_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type19_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type1_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type20_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language_2/function_type/function_type21_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type22_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type24_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type25_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type26_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type27_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type28_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type29_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type2_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type30_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type31_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type32_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type33_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type34_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type36_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type3_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type44_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language_2/function_type/function_type45_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type46_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type47_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type48_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type49_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type4_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language_2/function_type/function_type50_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type51_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type52_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language_2/function_type/function_type53_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type54_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type56_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type57_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type58_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type59_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type5_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type60_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/language_2/function_type/function_type61_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type62_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type63_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type64_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type65_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type66_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type6_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type7_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type80_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type81_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type82_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type83_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type84_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type85_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type86_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type87_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type88_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type89_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type8_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type90_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type96_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/function_type9_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language_2/function_type/test_generator.dart View 9 chunks +13 lines, -52 lines 0 comments Download
M tests/language_2/language_2_dartdevc.status View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Jennifer Messerly
TBR for bot greenness
3 years, 4 months ago (2017-08-17 20:49:33 UTC) #2
Jennifer Messerly
3 years, 4 months ago (2017-08-17 20:50:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
11f4152712a4f5a183fb6f4bfe5b7e2e7a400a8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698