Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: runtime/vm/runtime_entry_ia32.cc

Issue 2997993002: Revert "Reapply "Eliminate dependencies on assemblers and code stubs in precompiled runtime."" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/runtime_entry_arm64.cc ('k') | runtime/vm/runtime_entry_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/runtime_entry.h" 8 #include "vm/runtime_entry.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
11 #include "vm/stub_code.h" 11 #include "vm/stub_code.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 #define __ assembler-> 15 #define __ assembler->
16 16
17 uword RuntimeEntry::GetEntryPoint() const { 17 uword RuntimeEntry::GetEntryPoint() const {
18 return reinterpret_cast<uword>(function()); 18 return reinterpret_cast<uword>(function());
19 } 19 }
20 20
21 #if !defined(DART_PRECOMPILED_RUNTIME)
22 // Generate code to call into the stub which will call the runtime 21 // Generate code to call into the stub which will call the runtime
23 // function. Input for the stub is as follows: 22 // function. Input for the stub is as follows:
24 // For regular runtime calls - 23 // For regular runtime calls -
25 // ESP : points to the arguments and return value array. 24 // ESP : points to the arguments and return value array.
26 // ECX : address of the runtime function to call. 25 // ECX : address of the runtime function to call.
27 // EDX : number of arguments to the call as Smi. 26 // EDX : number of arguments to the call as Smi.
28 // For leaf calls the caller is responsible to setup the arguments 27 // For leaf calls the caller is responsible to setup the arguments
29 // and look for return values based on the C calling convention. 28 // and look for return values based on the C calling convention.
30 void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const { 29 void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {
31 if (is_leaf()) { 30 if (is_leaf()) {
32 ASSERT(argument_count == this->argument_count()); 31 ASSERT(argument_count == this->argument_count());
33 ExternalLabel label(GetEntryPoint()); 32 ExternalLabel label(GetEntryPoint());
34 __ call(&label); 33 __ call(&label);
35 } else { 34 } else {
36 // Argument count is not checked here, but in the runtime entry for a more 35 // Argument count is not checked here, but in the runtime entry for a more
37 // informative error message. 36 // informative error message.
38 __ movl(ECX, Immediate(GetEntryPoint())); 37 __ movl(ECX, Immediate(GetEntryPoint()));
39 __ movl(EDX, Immediate(argument_count)); 38 __ movl(EDX, Immediate(argument_count));
40 __ CallToRuntime(); 39 __ CallToRuntime();
41 } 40 }
42 } 41 }
43 #endif // !defined(DART_PRECOMPILED_RUNTIME)
44 42
45 } // namespace dart 43 } // namespace dart
46 44
47 #endif // defined TARGET_ARCH_IA32 45 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/runtime_entry_arm64.cc ('k') | runtime/vm/runtime_entry_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698