Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2997993002: Revert "Reapply "Eliminate dependencies on assemblers and code stubs in precompiled runtime."" (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, jsimmons1, cbernaschina
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Reapply "Eliminate dependencies on assemblers and code stubs in precompiled runtime."" This reverts commit 8ee4436355cf8434b99893fa014980adb17f572e. This change caused a 63% increase in AOT snapshot size of Flutter Gallery. Issue #30472 Committed: https://github.com/dart-lang/sdk/commit/9ce7fb59299996277002976da5c5603384c887be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -291 lines) Patch
M runtime/lib/errors.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M runtime/vm/assembler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/ast.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/ast_printer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/ast_transformer.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/block_scheduler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/branch_optimizer.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/cha.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/debugger.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 7 chunks +6 lines, -16 lines 0 comments Download
M runtime/vm/deferred_objects.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/disassembler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/disassembler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/disassembler_arm.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/disassembler_arm64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/disassembler_x64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/flag_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 3 chunks +41 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/il_printer.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/locations.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/megamorphic_cache_table.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/megamorphic_cache_table.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/object_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/redundancy_elimination.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/regexp_assembler_ir.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/runtime_entry.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/runtime_entry.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M runtime/vm/runtime_entry_arm.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry_arm64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry_ia32.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry_x64.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/stub_code.h View 3 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/stub_code.cc View 4 chunks +25 lines, -30 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/weak_code.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
rmacnak
3 years, 4 months ago (2017-08-17 20:32:19 UTC) #2
rmacnak
3 years, 4 months ago (2017-08-17 20:33:43 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9ce7fb59299996277002976da5c5603384c887be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698