Fix bots from block 47.

Fix bots from block 47.

https://build.chromium.org/p/client.dart/builders/dart2js-linux-d8-minified-5-5-be/builds/7016/steps/dart2js-d8%20tests/logs/stdio
https://build.chromium.org/p/client.dart/builders/dart2js-linux-d8-minified-5-5-be/builds/7016/steps/dart2js-d8-fast-startup%20tests/logs/stdio

BUG=
R=bkonyi@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/92809f0c5b9f9d644c58bb022a388ab02f1b8e3c

[jcollins, 2017-08-16 20:40:01]

jcollins@google.com changed reviewers:
+ bkonyi@google.com, rnystrom@google.com

[jcollins, 2017-08-16 20:40:02]

This seems to fix the bot that I broke without breaking other cases.

[cbernaschina, 2017-08-16 20:45:28]

On 2017/08/16 20:40:02, jcollins wrote:
> This seems to fix the bot that I broke without breaking other cases.

LGTM

[bkonyi, 2017-08-16 20:45:38]

LGTM with nit (see comment).

https://codereview.chromium.org/2997923002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_dart2js.status (right):

https://codereview.chromium.org/2997923002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dart2js.status:167: [ $compiler == dart2js &&
(($runtime != d8 && !$checked) || ($runtime == d8 && !$checked && $minified)) ]
[ $compiler == dart2js && !$checked && (($runtime != d8) || ($runtime == d8 &&
$minified)) ] is more condensed.

[Bob Nystrom, 2017-08-16 20:45:57]

lgtm

https://codereview.chromium.org/2997923002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_dart2js.status (right):

https://codereview.chromium.org/2997923002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dart2js.status:167: [ $compiler == dart2js &&
(($runtime != d8 && !$checked) || ($runtime == d8 && !$checked && $minified)) ]
That's a pretty complex expression. How about splitting it into two sections:

[ $compiler == dart2js && $runtime != d8 && !$checked ]
function_subtype_inline2_test: RuntimeError

[ $compiler == dart2js && $runtime == d8 && !$checked && $minified ]
function_subtype_inline2_test: RuntimeError

[jcollins, 2017-08-16 20:55:11]

https://codereview.chromium.org/2997923002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_dart2js.status (right):

https://codereview.chromium.org/2997923002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_dart2js.status:167: [ $compiler == dart2js &&
(($runtime != d8 && !$checked) || ($runtime == d8 && !$checked && $minified)) ]
On 2017/08/16 20:45:57, Bob Nystrom wrote:
> That's a pretty complex expression. How about splitting it into two sections:
> 
> [ $compiler == dart2js && $runtime != d8 && !$checked ]
> function_subtype_inline2_test: RuntimeError
> 
> [ $compiler == dart2js && $runtime == d8 && !$checked && $minified ]
> function_subtype_inline2_test: RuntimeError

Done.

[jcollins, 2017-08-16 20:56:11]

Description was changed from

==========
Fix bots from block 47.

https://build.chromium.org/p/client.dart/builders/dart2js-linux-d8-minified-5...
https://build.chromium.org/p/client.dart/builders/dart2js-linux-d8-minified-5...

BUG=
==========

to

==========
Fix bots from block 47.

https://build.chromium.org/p/client.dart/builders/dart2js-linux-d8-minified-5...
https://build.chromium.org/p/client.dart/builders/dart2js-linux-d8-minified-5...

BUG=
R=bkonyi@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/92809f0c5b9f9d644c58bb022a388ab02f1b8e3c
==========

[jcollins, 2017-08-16 20:56:12]

Committed patchset #2 (id:20001) manually as
92809f0c5b9f9d644c58bb022a388ab02f1b8e3c (presubmit successful).