Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2997843002: Implement methods in KernelClosedWorldMixin (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-15 14:06:30 UTC) #2
sra1
LGTM. Did no tests start to pass?
3 years, 4 months ago (2017-08-15 16:02:15 UTC) #3
sra1
Committed patchset #1 (id:1) manually as fd600fd334a6e9215195d4dfe67e9744d44a95d3 (presubmit successful).
3 years, 4 months ago (2017-08-15 21:19:01 UTC) #5
sra1
3 years, 4 months ago (2017-08-15 22:41:47 UTC) #6
Message was sent while issue was closed.
On 2017/08/15 21:19:01, sra1 wrote:
> Committed patchset #1 (id:1) manually as
> fd600fd334a6e9215195d4dfe67e9744d44a95d3 (presubmit successful).

I landed this with status updates (which I could not upload to an issue I don't
own)

Powered by Google App Engine
This is Rietveld 408576698