Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2997833002: Initial Kythe support for plugins (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -0 lines) Patch
A pkg/analyzer_plugin/lib/plugin/kythe_mixin.dart View 1 chunk +73 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/src/utilities/kythe/entries.dart View 1 chunk +47 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/kythe/entries.dart View 1 chunk +105 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/kythe_mixin_test.dart View 1 chunk +101 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/plugin/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-14 14:44:04 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-14 15:12:56 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-14 15:24:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f81034a73df25ed733e366afd3e085c434bc883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698