Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6064)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 299783004: Create PluginMetricsProvider class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.h
===================================================================
--- chrome/browser/metrics/metrics_service.h (revision 272171)
+++ chrome/browser/metrics/metrics_service.h (working copy)
@@ -41,6 +41,7 @@
class PrefService;
class PrefRegistrySimple;
class Profile;
+class PluginMetricsProvider;
class TemplateURLService;
namespace {
@@ -60,7 +61,6 @@
namespace content {
class RenderProcessHost;
class WebContents;
-struct WebPluginInfo;
}
namespace extensions {
@@ -192,12 +192,8 @@
content::NotificationObserver* observer);
// Implementation of content::BrowserChildProcessObserver
- virtual void BrowserChildProcessHostConnected(
- const content::ChildProcessData& data) OVERRIDE;
virtual void BrowserChildProcessCrashed(
const content::ChildProcessData& data) OVERRIDE;
- virtual void BrowserChildProcessInstanceCreated(
- const content::ChildProcessData& data) OVERRIDE;
// Implementation of content::NotificationObserver
virtual void Observe(int type,
@@ -296,8 +292,6 @@
NEED_TO_SHUTDOWN = ~CLEANLY_SHUTDOWN
};
- struct ChildProcessStats;
-
typedef std::vector<SyntheticTrialGroup> SyntheticTrialGroups;
// First part of the init task. Called on the FILE thread to load hardware
@@ -309,10 +303,9 @@
// loading plugin information.
void OnInitTaskGotHardwareClass(const std::string& hardware_class);
- // Callback from PluginService::GetPlugins() that continues the init task by
- // launching a task to gather Google Update statistics.
- void OnInitTaskGotPluginInfo(
- const std::vector<content::WebPluginInfo>& plugins);
+ // Called after the Plugin init task has been completed that continues the
+ // init task by launching a task to gather Google Update statistics.
+ void OnInitTaskGotPluginInfo();
// Called after GoogleUpdate init task has been completed that continues the
// init task by loading profiler data.
@@ -436,14 +429,6 @@
// Records that the browser was shut down cleanly.
void LogCleanShutdown();
- // Returns reference to ChildProcessStats corresponding to |data|.
- ChildProcessStats& GetChildProcessStats(
- const content::ChildProcessData& data);
-
- // Saves plugin-related updates from the in-object buffer to Local State
- // for retrieval next time we send a Profile log (generally next launch).
- void RecordPluginChanges(PrefService* pref);
-
// Records state that should be periodically saved, like uptime and
// buffered plugin stability statistics.
void RecordCurrentState(PrefService* pref);
@@ -505,8 +490,9 @@
// empty string.
std::string hardware_class_;
- // The list of plugins which was retrieved on the file thread.
- std::vector<content::WebPluginInfo> plugins_;
+#if defined(ENABLE_PLUGINS)
+ PluginMetricsProvider* plugin_metrics_provider_;
+#endif
#if defined(OS_WIN)
GoogleUpdateMetricsProviderWin* google_update_metrics_provider_;
@@ -534,9 +520,6 @@
WindowMap window_map_;
int next_window_id_;
- // Buffer of child process notifications for quick access.
- std::map<base::string16, ChildProcessStats> child_process_stats_buffer_;
-
// Weak pointers factory used to post task on different threads. All weak
// pointers managed by this factory have the same lifetime as MetricsService.
base::WeakPtrFactory<MetricsService> self_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698