Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: chrome/browser/metrics/metrics_service_unittest.cc

Issue 299783004: Create PluginMetricsProvider class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service_unittest.cc
===================================================================
--- chrome/browser/metrics/metrics_service_unittest.cc (revision 272445)
+++ chrome/browser/metrics/metrics_service_unittest.cc (working copy)
@@ -16,8 +16,6 @@
#include "components/metrics/metrics_service_observer.h"
#include "components/metrics/test_metrics_service_client.h"
#include "components/variations/metrics_util.h"
-#include "content/public/common/process_type.h"
-#include "content/public/common/webplugininfo.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/gfx/size.h"
@@ -172,15 +170,6 @@
} // namespace
-TEST_F(MetricsServiceTest, IsPluginProcess) {
- EXPECT_TRUE(
- MetricsService::IsPluginProcess(content::PROCESS_TYPE_PLUGIN));
- EXPECT_TRUE(
- MetricsService::IsPluginProcess(content::PROCESS_TYPE_PPAPI_PLUGIN));
- EXPECT_FALSE(
- MetricsService::IsPluginProcess(content::PROCESS_TYPE_GPU));
-}
-
TEST_F(MetricsServiceTest, InitialStabilityLogAfterCleanShutDown) {
EnableMetricsReporting();
GetLocalState()->SetBoolean(prefs::kStabilityExitedCleanly, true);
@@ -204,7 +193,6 @@
metrics::TestMetricsServiceClient client;
TestMetricsLog log("client", 1, &client);
log.RecordEnvironment(std::vector<metrics::MetricsProvider*>(),
- std::vector<content::WebPluginInfo>(),
std::vector<variations::ActiveGroupId>());
// Record stability build time and version from previous session, so that
« no previous file with comments | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698