Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2504)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 299783004: Create PluginMetricsProvider class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.h
===================================================================
--- chrome/browser/metrics/metrics_service.h (revision 272445)
+++ chrome/browser/metrics/metrics_service.h (working copy)
@@ -39,6 +39,7 @@
class MetricsReportingScheduler;
class PrefService;
class PrefRegistrySimple;
+class PluginMetricsProvider;
namespace base {
class DictionaryValue;
@@ -51,7 +52,6 @@
}
namespace content {
-struct WebPluginInfo;
}
namespace metrics {
@@ -171,12 +171,8 @@
virtual void InconsistencyDetectedInLoggedCount(int amount) OVERRIDE;
// Implementation of content::BrowserChildProcessObserver
- virtual void BrowserChildProcessHostConnected(
- const content::ChildProcessData& data) OVERRIDE;
virtual void BrowserChildProcessCrashed(
const content::ChildProcessData& data) OVERRIDE;
- virtual void BrowserChildProcessInstanceCreated(
- const content::ChildProcessData& data) OVERRIDE;
// This should be called when the application is not idle, i.e. the user seems
// to be interacting with the application.
@@ -274,8 +270,6 @@
NEED_TO_SHUTDOWN = ~CLEANLY_SHUTDOWN
};
- struct ChildProcessStats;
-
typedef std::vector<SyntheticTrialGroup> SyntheticTrialGroups;
// First part of the init task. Called on the FILE thread to load hardware
@@ -287,10 +281,9 @@
// loading plugin information.
void OnInitTaskGotHardwareClass(const std::string& hardware_class);
- // Callback from PluginService::GetPlugins() that continues the init task by
- // launching a task to gather Google Update statistics.
- void OnInitTaskGotPluginInfo(
- const std::vector<content::WebPluginInfo>& plugins);
+ // Called after the Plugin init task has been completed that continues the
+ // init task by launching a task to gather Google Update statistics.
+ void OnInitTaskGotPluginInfo();
// Called after GoogleUpdate init task has been completed that continues the
// init task by loading profiler data.
@@ -400,14 +393,6 @@
// Records that the browser was shut down cleanly.
void LogCleanShutdown();
- // Returns reference to ChildProcessStats corresponding to |data|.
- ChildProcessStats& GetChildProcessStats(
- const content::ChildProcessData& data);
-
- // Saves plugin-related updates from the in-object buffer to Local State
- // for retrieval next time we send a Profile log (generally next launch).
- void RecordPluginChanges(PrefService* pref);
-
// Records state that should be periodically saved, like uptime and
// buffered plugin stability statistics.
void RecordCurrentState(PrefService* pref);
@@ -418,10 +403,6 @@
// Sets the value of the specified path in prefs and schedules a save.
void RecordBooleanPrefValue(const char* path, bool value);
- // Returns true if process of type |type| should be counted as a plugin
- // process, and false otherwise.
- static bool IsPluginProcess(int process_type);
-
// Returns a list of synthetic field trials that were active for the entire
// duration of the current log.
void GetCurrentSyntheticFieldTrials(
@@ -480,8 +461,9 @@
// empty string.
std::string hardware_class_;
- // The list of plugins which was retrieved on the file thread.
- std::vector<content::WebPluginInfo> plugins_;
+#if defined(ENABLE_PLUGINS)
+ PluginMetricsProvider* plugin_metrics_provider_;
+#endif
#if defined(OS_WIN)
GoogleUpdateMetricsProviderWin* google_update_metrics_provider_;
@@ -509,9 +491,6 @@
WindowMap window_map_;
int next_window_id_;
- // Buffer of child process notifications for quick access.
- std::map<base::string16, ChildProcessStats> child_process_stats_buffer_;
-
// Weak pointers factory used to post task on different threads. All weak
// pointers managed by this factory have the same lifetime as MetricsService.
base::WeakPtrFactory<MetricsService> self_ptr_factory_;
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698