Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 299783004: Create PluginMetricsProvider class. (Closed)

Created:
6 years, 7 months ago by Alexei Svitkine (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Create PluginMetricsProvider class. Also changes ProvideStabilityMetrics() to take a SystemProfileProto* instead of the stability section, since the plugin provider needs to inspect things in the system profile when writing its stability data. Also, cleans up some header includes. BUG=374220 R=isherman@chromium.org, thestig@chromium.org TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272462

Patch Set 1 : #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -474 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/android_metrics_provider.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/android_metrics_provider.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_stability_metrics_provider.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/chrome_stability_metrics_provider.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.h View 1 2 3 4 5 5 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 2 3 4 5 10 chunks +4 lines, -132 lines 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 2 3 4 5 14 chunks +3 lines, -90 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 2 3 4 5 9 chunks +7 lines, -28 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 5 12 chunks +41 lines, -193 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 2 3 4 5 3 chunks +0 lines, -12 lines 0 comments Download
A chrome/browser/metrics/plugin_metrics_provider.h View 1 2 3 1 chunk +95 lines, -0 lines 0 comments Download
A chrome/browser/metrics/plugin_metrics_provider.cc View 1 2 3 1 chunk +350 lines, -0 lines 0 comments Download
A chrome/browser/metrics/plugin_metrics_provider_unittest.cc View 1 2 3 1 chunk +102 lines, -0 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M components/metrics/metrics_provider.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Alexei Svitkine (slow)
6 years, 7 months ago (2014-05-22 12:44:38 UTC) #1
Ilya Sherman
https://chromiumcodereview.appspot.com/299783004/diff/60001/chrome/browser/metrics/metrics_service.cc File chrome/browser/metrics/metrics_service.cc (right): https://chromiumcodereview.appspot.com/299783004/diff/60001/chrome/browser/metrics/metrics_service.cc#newcode880 chrome/browser/metrics/metrics_service.cc:880: const base::Closure got_metrics_callback = nit: Perhaps "got_plugin_info_callback"? https://chromiumcodereview.appspot.com/299783004/diff/60001/chrome/browser/metrics/plugin_metrics_provider.cc File ...
6 years, 7 months ago (2014-05-22 14:52:20 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/299783004/diff/60001/chrome/browser/metrics/metrics_service.cc File chrome/browser/metrics/metrics_service.cc (right): https://codereview.chromium.org/299783004/diff/60001/chrome/browser/metrics/metrics_service.cc#newcode880 chrome/browser/metrics/metrics_service.cc:880: const base::Closure got_metrics_callback = On 2014/05/22 14:52:20, Ilya Sherman ...
6 years, 7 months ago (2014-05-22 15:38:53 UTC) #3
Ilya Sherman
LGTM. Thanks, Alexei!
6 years, 7 months ago (2014-05-22 15:44:03 UTC) #4
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-22 15:48:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/299783004/130001
6 years, 7 months ago (2014-05-22 15:49:58 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 20:04:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 20:10:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69313)
6 years, 7 months ago (2014-05-22 20:10:41 UTC) #9
Alexei Svitkine (slow)
TBR thestig for trivial changes to chrome/browser/browser_process_impl.cc and chrome/browser/prefs/browser_prefs.cc
6 years, 7 months ago (2014-05-22 22:48:34 UTC) #10
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-22 22:49:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/299783004/140001
6 years, 7 months ago (2014-05-22 22:51:06 UTC) #12
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-22 22:57:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/299783004/160001
6 years, 7 months ago (2014-05-22 22:59:05 UTC) #14
Lei Zhang
On 2014/05/22 22:48:34, Alexei Svitkine wrote: > TBR thestig for trivial changes to chrome/browser/browser_process_impl.cc and ...
6 years, 7 months ago (2014-05-22 23:10:34 UTC) #15
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 7 months ago (2014-05-23 08:25:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/299783004/180001
6 years, 7 months ago (2014-05-23 08:26:39 UTC) #17
Alexei Svitkine (slow)
6 years, 7 months ago (2014-05-23 09:57:48 UTC) #18
Message was sent while issue was closed. 
Committed patchset #6 manually as r272462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698