Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issue 2997823002: Fix virtual-collection header flickering (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix virtual-collection header flickering On Firefox and probably other browsers the header of the virtual-collection elements must be updated in the scroll event listener to avoid the flickering of the screen. R=asiva@google.com TBR=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b7767a92f271579f808e4571f2f8255fefa7d6bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M runtime/observatory/lib/src/elements/containers/virtual_collection.dart View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
cbernaschina
3 years, 4 months ago (2017-08-12 00:46:34 UTC) #1
siva
lgtm
3 years, 4 months ago (2017-08-14 20:29:41 UTC) #2
cbernaschina
3 years, 4 months ago (2017-08-14 21:34:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7767a92f271579f808e4571f2f8255fefa7d6bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698