Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2997753002: Revert "Remove support for "packages" URL from testing server." (Closed)

Created:
3 years, 4 months ago by sra1
Modified:
3 years, 4 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove support for "packages" URL from testing server." This reverts commit f38f91bb7e8cceff5149c5ee742d1a501749e4e3. Lots of browser bots are red with this change. Hopefully it can be recommitted atomically with changes that fix the redness. TBR=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/88388cb5ca3dc98533487ceec1b04ac8d4f18ab2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -8 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/configuration.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/http_server.dart View 10 chunks +50 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
sra1
3 years, 4 months ago (2017-08-11 00:04:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
88388cb5ca3dc98533487ceec1b04ac8d4f18ab2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698