Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2997723002: Revert "Migrating a block of dart 2:" (Closed)

Created:
3 years, 4 months ago by mkroghj
Modified:
3 years, 4 months ago
Reviewers:
sortie
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Migrating a block of dart 2:" This reverts commit fa59030f18c5015f7e25832d9247cc2967e99aa1. TBR=sortie@google.com Committed: https://github.com/dart-lang/sdk/commit/f0e8bb629b9c9a0c7028d116f1642a71847175ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -9323 lines) Patch
A + tests/language/class_keyword_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language/class_literal_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download
A + tests/language/class_override_test.dart View 2 chunks +8 lines, -3 lines 0 comments Download
A + tests/language/class_syntax2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/class_syntax_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/class_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/classes_static_method_clash_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure6_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure7_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure8_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_break1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_break2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_break_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_call_wrong_argument_count_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_cycles_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_in_constructor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_in_field_initializer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/closure_in_initializer2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_in_initializer_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
A + tests/language/closure_internals_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/language/closure_parameter_types_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_self_reference_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/closure_shared_state_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/language.status View 4 chunks +4 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +97 lines, -0 lines 0 comments Download
D tests/language_2/class_keyword_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language_2/class_literal_static_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/language_2/class_literal_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D tests/language_2/class_override_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language_2/class_syntax2_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_2/class_syntax_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/language_2/class_test.dart View 1 chunk +0 lines, -177 lines 0 comments Download
D tests/language_2/classes_static_method_clash_test.dart View 1 chunk +0 lines, -8167 lines 0 comments Download
D tests/language_2/closure2_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language_2/closure3_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/language_2/closure4_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/language_2/closure5_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/language_2/closure6_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language_2/closure7_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D tests/language_2/closure8_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language_2/closure_break1_test.dart View 1 chunk +0 lines, -52 lines 0 comments Download
D tests/language_2/closure_break2_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tests/language_2/closure_break_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D tests/language_2/closure_call_wrong_argument_count_negative_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language_2/closure_cycles_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/language_2/closure_in_constructor_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language_2/closure_in_field_initializer_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/language_2/closure_in_initializer2_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/language_2/closure_in_initializer_static_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/language_2/closure_in_initializer_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/language_2/closure_internals_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/language_2/closure_parameter_types_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/language_2/closure_self_reference_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
D tests/language_2/closure_shared_state_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
M tests/language_2/language_2.status View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/language_2/language_2_analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language_2/language_2_dart2js.status View 2 chunks +0 lines, -100 lines 0 comments Download
M tests/language_2/language_2_flutter.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language_2/language_2_precompiled.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language_2/language_2_vm.status View 1 chunk +0 lines, -3 lines 0 comments Download
A + tests/language_strong/class_keyword_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language_strong/class_literal_test.dart View 1 chunk +60 lines, -0 lines 0 comments Download
A + tests/language_strong/class_override_test.dart View 2 chunks +8 lines, -3 lines 0 comments Download
A + tests/language_strong/class_syntax2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/class_syntax_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/class_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/classes_static_method_clash_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure6_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure7_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure8_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_break1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_break2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_break_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_call_wrong_argument_count_negative_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_cycles_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_in_constructor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_in_field_initializer_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_in_initializer2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_in_initializer_test.dart View 1 chunk +24 lines, -4 lines 0 comments Download
A + tests/language_strong/closure_internals_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/language_strong/closure_parameter_types_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_self_reference_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_strong/closure_shared_state_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mkroghj
3 years, 4 months ago (2017-08-10 12:51:03 UTC) #1
mkroghj
Committed patchset #1 (id:1) manually as f0e8bb629b9c9a0c7028d116f1642a71847175ec.
3 years, 4 months ago (2017-08-10 12:51:35 UTC) #3
sortie
3 years, 4 months ago (2017-08-10 12:53:00 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698