Fix the script analyzer/tool/generate_files

Fix the script analyzer/tool/generate_files

* The script had stopped working due to a pair of changes in Dart.
  First, building Dart no longer produces a packages directory to use
  as a package-root.

  Second, generated Dart files are now formatted and the formatting
  code relies on invoking Dart from the Dart SDK in order to find
  dartfmt.  (Specifically: invoking Dart from the build directory does
  not work because there is no dartfmt there, and invoking Dart via
  sdk/bin/dart from the SDK repository does not work because it is a
  shell script that invokes Dart from the build directory.)

* Enable the test that the generated summary code has not changed.

* Regenerate the generated summary code.

BUG=
R=paulberry@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/bae72c382ab9bada7d47f94ca8b0a066702bbe68

[Kevin Millikin (Google), 2017-08-10 12:06:00]

kmillikin@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com, whesse@google.com

[Kevin Millikin (Google), 2017-08-10 12:06:01]

https://codereview.chromium.org/2997703002/diff/1/pkg/analyzer/tool/generate_...
File pkg/analyzer/tool/generate_files (right):

https://codereview.chromium.org/2997703002/diff/1/pkg/analyzer/tool/generate_...
pkg/analyzer/tool/generate_files:34:
BIN_DIR="${ROOT_DIR}/xcodebuild/$DART_CONFIGURATION/dart-sdk/bin"
Note that this requires one to build the target create_sdk where before it only
required, e.g., to build the target runtime.

[Bill Hesse, 2017-08-10 12:24:09]

If the test that the generated files are consistent is run on the VM builders,
there would be a problem, because they don't create the sdk.

If this test is run in presubmit or any triggered way, we break the workflow of
any developers that don't build the sdk.

Why doesn't this use the checked-in SDK in tools/sdks/[system]/dart-sdk?  The
dartfmt in there
is the one that is used in the presubmit check of the formatting of changed
files, and we have python and dart code to find the correct path
(tools/utils.py:CheckedInSdkPath)

[Kevin Millikin (Google), 2017-08-10 14:29:03]

On 2017/08/10 12:24:09, Bill Hesse wrote:
> If the test that the generated files are consistent is run on the VM builders,
> there would be a problem, because they don't create the sdk.
> 
> If this test is run in presubmit or any triggered way, we break the workflow
of
> any developers that don't build the sdk.
> 
> Why doesn't this use the checked-in SDK in tools/sdks/[system]/dart-sdk?  The
> dartfmt in there
> is the one that is used in the presubmit check of the formatting of changed
> files, and we have python and dart code to find the correct path
> (tools/utils.py:CheckedInSdkPath)

I discussed this offline with Bill, and I think the way it is in the CL is the
way we need it to be.  The test does not use the shell script, it regenerates
the file by calling Dart code directly.  And the shell script should use the
create_sdk built dartfmt when it regenerates the files because the test is run
using that built dartfmt.

[Brian Wilkerson, 2017-08-10 15:53:29]

I'm going to defer to Paul on this one.

[Bill Hesse, 2017-08-10 15:55:41]

lgtm

[Paul Berry, 2017-08-10 16:38:46]

lgtm

[Kevin Millikin (Google), 2017-08-11 10:05:52]

Description was changed from

==========
Fix the script analyzer/tool/generate_files

* The script had stopped working due to a pair of changes in Dart.
  First, building Dart no longer produces a packages directory to use
  as a package-root.

  Second, generated Dart files are now formatted and the formatting
  code relies on invoking Dart from the Dart SDK in order to find
  dartfmt.  (Specifically: invoking Dart from the build directory does
  not work because there is no dartfmt there, and invoking Dart via
  sdk/bin/dart from the SDK repository does not work because it is a
  shell script that invokes Dart from the build directory.)

* Enable the test that the generated summary code has not changed.

* Regenerate the generated summary code.

BUG=
==========

to

==========
Fix the script analyzer/tool/generate_files

* The script had stopped working due to a pair of changes in Dart.
  First, building Dart no longer produces a packages directory to use
  as a package-root.

  Second, generated Dart files are now formatted and the formatting
  code relies on invoking Dart from the Dart SDK in order to find
  dartfmt.  (Specifically: invoking Dart from the build directory does
  not work because there is no dartfmt there, and invoking Dart via
  sdk/bin/dart from the SDK repository does not work because it is a
  shell script that invokes Dart from the build directory.)

* Enable the test that the generated summary code has not changed.

* Regenerate the generated summary code.

BUG=
R=paulberry@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bae72c382ab9bada7d47f94ca8b0a066702bbe68
==========

[Kevin Millikin (Google), 2017-08-11 10:05:54]

Committed patchset #1 (id:1) manually as
bae72c382ab9bada7d47f94ca8b0a066702bbe68 (presubmit successful).