Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2997673002: Add cases to all configs and allow for running a single test. (Closed)

Created:
3 years, 4 months ago by jcollins
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add cases to all configs and allow for running a single test. This adds analyzer-strong-checked as distinct from analyzer-strong, which seems to be how the bots run it. Also adds the d8 runtime to dart2js as that was the cause of some bot breakage. Finally, you can now run one test by just passing a single parameter. BUG= R=bkonyi@google.com, jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/d2f2b0f44dd62cb1f0f095ac6ae1095e1a4bebbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M tools/migration/bin/run_tests.dart View 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jcollins
3 years, 4 months ago (2017-08-09 17:19:53 UTC) #3
Jennifer Messerly
fwiw, lgtm :)
3 years, 4 months ago (2017-08-09 17:26:26 UTC) #5
bkonyi
LGTM!
3 years, 4 months ago (2017-08-09 19:25:01 UTC) #6
jcollins
3 years, 4 months ago (2017-08-14 14:48:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d2f2b0f44dd62cb1f0f095ac6ae1095e1a4bebbe.

Powered by Google App Engine
This is Rietveld 408576698