Issue 2997653002: update status for passing ddc tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2997653002: update status for passing ddc tests (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly

Modified:
3 years, 4 months ago

Reviewers:
Leaf

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

update status for passing ddc tests Committed: https://github.com/dart-lang/sdk/commit/03d578ed850909b73138cbc0c95555dc3512bb53

Patch Set 1 #

Total comments: 1

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/language_2/language_2_dartdevc.status	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

TBR for bots https://codereview.chromium.org/2997653002/diff/1/tests/language_2/language_2_dartdevc.status File tests/language_2/language_2_dartdevc.status (right): https://codereview.chromium.org/2997653002/diff/1/tests/language_2/language_2_dartdevc.status#newcode47 tests/language_2/language_2_dartdevc.status:47: function_type/function_type50_test: RuntimeError # Issue 29920 now ...

3 years, 4 months ago (2017-08-09 05:57:46 UTC) #2

Jennifer Messerly

Committed patchset #1 (id:1) manually as 03d578ed850909b73138cbc0c95555dc3512bb53 (presubmit successful).

3 years, 4 months ago (2017-08-09 05:57:58 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages