Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 299763002: speed up benches: postpone hash computation in PictureRenderer.cpp (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
Reviewers:
borenet, benchen
CC:
skia-review_googlegroups.com, fmalita_google_do_not_use
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

speed up benches: postpone hash computation in PictureRenderer.cpp fixes phantom performance regression after https://codereview.chromium.org/273783004 Committed: http://code.google.com/p/skia/source/detail?r=14819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/PictureRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
epoger
PTAL
6 years, 7 months ago (2014-05-20 19:42:32 UTC) #1
borenet
LGTM
6 years, 7 months ago (2014-05-20 19:45:48 UTC) #2
epoger
Ben- Should I go ahead and commit this once the tree is open?
6 years, 7 months ago (2014-05-20 20:33:03 UTC) #3
epoger
On 2014/05/20 20:33:03, epoger wrote: > Ben- Should I go ahead and commit this once ...
6 years, 7 months ago (2014-05-20 20:34:01 UTC) #4
benchen
The CQ bit was checked by bensong@google.com
6 years, 7 months ago (2014-05-20 20:42:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/299763002/1
6 years, 7 months ago (2014-05-20 20:42:53 UTC) #6
benchen
On 2014/05/20 20:42:32, benchen wrote: > The CQ bit was checked by mailto:bensong@google.com Sorry I ...
6 years, 7 months ago (2014-05-20 20:43:12 UTC) #7
epoger
Note- I believe the CommitQueue will commit this change when the tree is reopened, so ...
6 years, 7 months ago (2014-05-20 20:48:58 UTC) #8
benchen
On 2014/05/20 20:48:58, epoger wrote: > Note- I believe the CommitQueue will commit this change ...
6 years, 7 months ago (2014-05-20 20:55:33 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 11:57:18 UTC) #10
Message was sent while issue was closed.
Change committed as 14819

Powered by Google App Engine
This is Rietveld 408576698