chrome/browser/guest_view/guest_view_manager.h - Issue 299753011: Move allocate instance id to chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_manager.h

Issue 299753011: Move allocate instance id to chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from fady Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guest_view/guest_view_manager.h

diff --git a/chrome/browser/guest_view/guest_view_manager.h b/chrome/browser/guest_view/guest_view_manager.h

index eaf195efce6bec63687fd875616ff24bc970ce13..789ef06606959f4c7a6dce64df9602f1560f3fcd 100644

--- a/chrome/browser/guest_view/guest_view_manager.h

+++ b/chrome/browser/guest_view/guest_view_manager.h

@@ -43,8 +43,6 @@ class GuestViewManager : public content::BrowserPluginGuestManager,

virtual content::WebContents* CreateGuest(

content::SiteInstance* embedder_site_instance,

int instance_id,

- const std::string& storage_partition_id,

- bool persist_storage,

scoped_ptr<base::DictionaryValue> extra_params) OVERRIDE;

virtual int GetNextInstanceID() OVERRIDE;

virtual void MaybeGetGuestByInstanceIDOrKill(