chrome/browser/guest_view/web_view/web_view_guest.h - Issue 299753011: Move allocate instance id to chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 299753011: Move allocate instance id to chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: refactor one method, Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/guest_view/web_view/web_view_guest.h

diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h

index f7b6d2ba0a7ee606a241e1cb30202a32031a3d32..036297ab93b6a48a2512ba773ed1add4e1022989 100644

--- a/chrome/browser/guest_view/web_view/web_view_guest.h

+++ b/chrome/browser/guest_view/web_view/web_view_guest.h

@@ -81,7 +81,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,

const base::string16& source_id) OVERRIDE;

virtual void LoadProgressed(double progress) OVERRIDE;

virtual void Close() OVERRIDE;

- virtual void DidAttach() OVERRIDE;

+ virtual void DidAttach(const base::DictionaryValue& extra_params) OVERRIDE;

virtual void EmbedderDestroyed() OVERRIDE;

virtual void FindReply(int request_id,

int number_of_matches,