Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: chrome/browser/extensions/api/webview/webview_api.cc

Issue 299753011: Move allocate instance id to chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: refactor one method, Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/webview/webview_api.cc
diff --git a/chrome/browser/extensions/api/webview/webview_api.cc b/chrome/browser/extensions/api/webview/webview_api.cc
index cfa2e34e948dbba6db75d3766a594f6bbe501409..f87d2501f4f0ea3b5b2675f6c79a9d9bb43f069f 100644
--- a/chrome/browser/extensions/api/webview/webview_api.cc
+++ b/chrome/browser/extensions/api/webview/webview_api.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/extensions/api/context_menus/context_menus_api.h"
#include "chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h"
#include "chrome/browser/extensions/tab_helper.h"
+#include "chrome/browser/guest_view/guest_view_manager.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/extensions/api/webview.h"
#include "content/public/browser/render_process_host.h"
@@ -89,6 +90,31 @@ bool WebviewContextMenusCreateFunction::RunAsync() {
return success;
}
+WebviewAllocateInstanceIdFunction::WebviewAllocateInstanceIdFunction() {
+ printf("++++ %s\n", __PRETTY_FUNCTION__);
+}
+
+bool WebviewAllocateInstanceIdFunction::RunAsync() {
+ printf("++++ %s\n", __PRETTY_FUNCTION__);
+ int instanceId =
+ GuestViewManager::FromBrowserContext(
+ browser_context())->GetNextInstanceID();
Fady Samuel 2014/05/27 14:19:06 Let's make this a "GuestView" API, as this will ap
lazyboy 2014/05/27 20:43:00 Done.
+ SetResult(base::Value::CreateIntegerValue(instanceId));
+ SendResponse(true);
+ return true;
+}
+
+bool WebviewNavigateFunction::RunAsyncSafe(WebViewGuest* guest) {
+ printf("++++ %s, guest = [%p]\n", __PRETTY_FUNCTION__, guest);
+ scoped_ptr<webview::Navigate::Params> params(
+ webview::Navigate::Params::Create(*args_));
+ EXTENSION_FUNCTION_VALIDATE(params.get());
+ std::string src = params->src;
+ printf("src was: %s\n", src.c_str());
+ guest->NavigateGuest(src);
+ return true;
+}
+
bool WebviewContextMenusUpdateFunction::RunAsync() {
scoped_ptr<webview::ContextMenusUpdate::Params> params(
webview::ContextMenusUpdate::Params::Create(*args_));

Powered by Google App Engine
This is Rietveld 408576698