Move allocate instance id to chrome/.

chrome/browser/guest_view/guest_view_manager.cc

Index: chrome/browser/guest_view/guest_view_manager.cc
diff --git a/chrome/browser/guest_view/guest_view_manager.cc b/chrome/browser/guest_view/guest_view_manager.cc
index d3be4e6d876976ba44ea7d7b388ea76b37576bf7..91668cbbc9027f61a188f28d8f842bc7a0079122 100644
--- a/chrome/browser/guest_view/guest_view_manager.cc
+++ b/chrome/browser/guest_view/guest_view_manager.cc
@@ -8,6 +8,7 @@
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/guest_view/guest_view_base.h"
 #include "chrome/browser/guest_view/guest_view_constants.h"
+#include "chrome/browser/guest_view/web_view/web_view_guest.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/render_process_host.h"
@@ -59,9 +60,16 @@ int GuestViewManager::GetNextInstanceID() {
 content::WebContents* GuestViewManager::CreateGuest(
     content::SiteInstance* embedder_site_instance,
     int instance_id,
-    const std::string& storage_partition_id,
-    bool persist_storage,
     scoped_ptr<base::DictionaryValue> extra_params) {
+  std::string storage_partition_id;
+  bool persist_storage = false;
+  std::string storage_partition_string;
+  if (extra_params->GetString(guestview::kStoragePartitionId,

[Fady Samuel, 2014/06/03 19:40:40]

The partition ID is really a <webview> concept. Can we move this GetString check
into ParsePartitionParam? Perhaps it can do the check there? kStoragePartitionId
should probably also be in web_view_constants.

[lazyboy, 2014/06/03 22:30:11]

Done.

+                              &storage_partition_string)) {
+    WebViewGuest::ParsePartitionParam(
+        storage_partition_string, &storage_partition_id, &persist_storage);
+  }
+
   content::RenderProcessHost* embedder_process_host =
       embedder_site_instance->GetProcess();
   // Validate that the partition id coming from the renderer is valid UTF-8,