Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 299753005: Update the directory in the tree when it is notified to get changed. (Closed)

Created:
6 years, 7 months ago by fukino
Modified:
6 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Update the directory in the tree when it is notified to get changed. util.isDescendantEntry(entryA, entryB) returns false if entryA and entryB is same, so the directory tree failed to update the directory which is notified to get changed. util.isSameEntry() is added to the condition. BUG=375595 TEST=manually confirmed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/directory_tree.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
fukino
yoshiki san, PTAL. This fix is simple and symptom will be understood easier by the ...
6 years, 7 months ago (2014-05-21 05:38:33 UTC) #1
yoshiki
lgtm
6 years, 7 months ago (2014-05-21 05:50:28 UTC) #2
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-21 05:51:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/299753005/1
6 years, 7 months ago (2014-05-21 05:53:21 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 23:39:42 UTC) #5
Message was sent while issue was closed.
Change committed as 272015

Powered by Google App Engine
This is Rietveld 408576698