Issue 299753002: [NaCl SDK Docs] PPAPI docs use a new template without a sidenav.

Issue 299753002: [NaCl SDK Docs] PPAPI docs use a new template without a sidenav. (Closed)

Created:
6 years, 7 months ago by binji

Modified:
6 years, 7 months ago

Reviewers:
sbc, Sam Clegg, not at google - send to devlin

CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg, extensions-reviews_chromium.org, egilmore, JF

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK Docs] PPAPI docs use a new template without a sidenav. This is not perfect, as some function names are still to long. But it improves most of them. I've also added the ability to specify the chromesite template to use from within the .rst file. BUG=374811 TEST=locally ran the server R=kalman@chromium.org, sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271937

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -17 lines)			Patch
A	chrome/common/extensions/docs/templates/private/standard_nacl_api.html	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/doc/_sphinxext/chromesite_builder.py	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	native_client_sdk/src/doc/doxygen/footer.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	native_client_sdk/src/doc/doxygen/header.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	native_client_sdk/src/doc/pepper_dev/c/index.rst	View		5 chunks	+9 lines, -1 line	0 comments	Download
M	native_client_sdk/src/doc/pepper_dev/cpp/index.rst	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	native_client_sdk/src/doc/pepper_stable/c/index.rst	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/doc/pepper_stable/cpp/index.rst	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/doc/pepper_stable/index.rst	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

binji

+kalman: chrome/common/extensions/docs/templates +sbc: native_client_sdk/src/doc

6 years, 7 months ago (2014-05-20 19:23:00 UTC) #1

not at google - send to devlin

lgtm https://codereview.chromium.org/299753002/diff/1/chrome/common/extensions/docs/templates/private/standard_nacl_api.html File chrome/common/extensions/docs/templates/private/standard_nacl_api.html (right): https://codereview.chromium.org/299753002/diff/1/chrome/common/extensions/docs/templates/private/standard_nacl_api.html#newcode9 chrome/common/extensions/docs/templates/private/standard_nacl_api.html:9: is this blank line important?

6 years, 7 months ago (2014-05-20 19:44:58 UTC) #2

binji

https://codereview.chromium.org/299753002/diff/1/chrome/common/extensions/docs/templates/private/standard_nacl_api.html File chrome/common/extensions/docs/templates/private/standard_nacl_api.html (right): https://codereview.chromium.org/299753002/diff/1/chrome/common/extensions/docs/templates/private/standard_nacl_api.html#newcode9 chrome/common/extensions/docs/templates/private/standard_nacl_api.html:9: On 2014/05/20 19:44:58, kalman wrote: > is this blank ...

6 years, 7 months ago (2014-05-20 20:05:31 UTC) #3

binji

6 years, 7 months ago (2014-05-21 19:10:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r271937 (presubmit successful).

Expand Messages | Collapse Messages