Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2997513002: Use "bool" as the downward inference context for assert conditions. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use "bool" as the downward inference context for assert conditions. This addresses the type inference part of #30326. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ae4cbb50af4d1c6055a3cf66c4992f1e91df4ce7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/assert.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/assert.dart.strong.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/assert_initializer.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/assert_initializer.dart.strong.expect View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 4 months ago (2017-08-07 16:50:06 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-07 16:51:29 UTC) #3
Paul Berry
3 years, 4 months ago (2017-08-07 17:36:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ae4cbb50af4d1c6055a3cf66c4992f1e91df4ce7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698