Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2997473002: Add documentation comments for enum and enum values. Resynthesize in analyzer. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add documentation comments for enum and enum values. Resynthesize in analyzer. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f5d26882069c18b14b6c367584e5aa5f22ccf4de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -42 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +8 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/enum_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 9 chunks +19 lines, -17 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-08-04 17:39:34 UTC) #1
Paul Berry
lgtm
3 years, 4 months ago (2017-08-04 19:38:12 UTC) #2
scheglov
3 years, 4 months ago (2017-08-04 23:53:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f5d26882069c18b14b6c367584e5aa5f22ccf4de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698