Support --use-kernel in memory_compiler

Support --use-kernel in memory_compiler

- and start using it to deprecate --use-kernel-in-ssa

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/583d3c5e844a970094ef7f8855858cba3610bb58

[Johnni Winther, 2017-08-23 13:50:27]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-23 20:45:18]

if you don't mind, lets land it after I fix the issue in the FE (or if Peter
approves, feel free to land that piece on my behalf)

https://codereview.chromium.org/2997413002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2997413002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_loader.dart:104: uri.scheme !=
"memory") {
If you don't mind, let's revert the change on this file.

I just sent https://codereview.chromium.org/3006483002/ which basically deletes
this check and delegates to the underlying filesystem to let it define what's
supported.

https://codereview.chromium.org/2997413002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/literals_test.dart (right):

https://codereview.chromium.org/2997413002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/literals_test.dart:18: useKernelInSsa: true);
what about all the other check calls in this file?

[Johnni Winther, 2017-08-24 06:47:54]

https://codereview.chromium.org/2997413002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2997413002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_loader.dart:104: uri.scheme !=
"memory") {
On 2017/08/23 20:45:18, Siggi Cherem (dart-lang) wrote:
> If you don't mind, let's revert the change on this file.
> 
> I just sent https://codereview.chromium.org/3006483002/ which basically
deletes
> this check and delegates to the underlying filesystem to let it define what's
> supported.

I thought this might provoke you to fix the issue ;)

https://codereview.chromium.org/2997413002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/literals_test.dart (right):

https://codereview.chromium.org/2997413002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/literals_test.dart:18: useKernelInSsa: true);
On 2017/08/23 20:45:18, Siggi Cherem (dart-lang) wrote:
> what about all the other check calls in this file?

They work with 'useKernel'.

[Johnni Winther, 2017-08-24 13:44:07]

PTAL (this assume your fix is in)

[Siggi Cherem (dart-lang), 2017-08-24 15:32:15]

lgtm

https://codereview.chromium.org/2997413002/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/literals_test.dart (right):

https://codereview.chromium.org/2997413002/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/literals_test.dart:18: useKernelInSsa: true);
On 2017/08/24 06:47:54, Johnni Winther wrote:
> On 2017/08/23 20:45:18, Siggi Cherem (dart-lang) wrote:
> > what about all the other check calls in this file?
> 
> They work with 'useKernel'.

sorry - the `useKernel: false` in `compile` misled me to believe that both flags
were off. Makes sense now.

[Johnni Winther, 2017-08-30 08:42:15]

Description was changed from

==========
Support --use-kernel in memory_compiler

- and start using it to deprecate --use-kernel-in-ssa
==========

to

==========
Support --use-kernel in memory_compiler

- and start using it to deprecate --use-kernel-in-ssa

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/583d3c5e844a970094ef7f8855858cba3610bb58
==========

[Johnni Winther, 2017-08-30 08:42:16]

Committed patchset #2 (id:20001) manually as
583d3c5e844a970094ef7f8855858cba3610bb58 (presubmit successful).