Adding adjusted `void` tests from CL 2699073003

Adding adjusted `void` tests from CL 2699073003

These tests exercise the static and dynamic semantics of `void` used in
those new locations where 'generalized void' added support form it.

They came from CL 2699073003 and were adjusted to match the result of
discussions taken after their creation (in particular, `b ? e1 : e2`
was used and expected to be allowed, but it is now a static warning in
Dart 1.x and a compile-time error in Dart 2).

The tests are located in tests/language_2, and they are testing Dart 2
behavior. In particular, usage of a value of static type `void` is a
compile-time error rather than a static warning, and `void` is
considered equivalent to `Object` in subtype checks, both statically
and dynamically.

We do not currently have any tools which will conform to the
expectations of these tests. Status files have been adjested
accordingly.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/811ae1855d747a6a4c1b83b2027cd862a0ba870e

[eernst, 2017-08-22 13:23:22]

eernst@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-08-25 07:40:46]

LGTM.

https://codereview.chromium.org/2997353002/diff/20001/tests/language_2/void_t...
File tests/language_2/void_type_function_types_test.dart (right):

https://codereview.chromium.org/2997353002/diff/20001/tests/language_2/void_t...
tests/language_2/void_type_function_types_test.dart:64: throwsInChecked(() {
expectsH(f); });  //# 00: compile-time error
Since this is strong mode only (which implies checked), consider removing the
"throwsInChecked" entirely.

[eernst, 2017-08-25 07:49:44]

Review response.

https://codereview.chromium.org/2997353002/diff/20001/tests/language_2/void_t...
File tests/language_2/void_type_function_types_test.dart (right):

https://codereview.chromium.org/2997353002/diff/20001/tests/language_2/void_t...
tests/language_2/void_type_function_types_test.dart:64: throwsInChecked(() {
expectsH(f); });  //# 00: compile-time error
On 2017/08/25 07:40:46, floitsch wrote:
> Since this is strong mode only (which implies checked), consider removing the
> "throwsInChecked" entirely.

Done.

[eernst, 2017-08-25 08:03:28]

Description was changed from

==========
Adding adjusted `void` tests from CL 2699073003

These tests exercise the static and dynamic semantics of `void` used in
those new locations where 'generalized void' added support form it.

They came from CL 2699073003 and were adjusted to match the result of
discussions taken after their creation (in particular, `b ? e1 : e2`
was used and expected to be allowed, but it is now a static warning in
Dart 1.x and a compile-time error in Dart 2).

The tests are located in tests/language_2, and they are testing Dart 2
behavior. In particular, usage of a value of static type `void` is a
compile-time error rather than a static warning, and `void` is
considered equivalent to `Object` in subtype checks, both statically
and dynamically.

We do not currently have any tools which will conform to the
expectations of these tests. Status files have been adjested
accordingly.
==========

to

==========
Adding adjusted `void` tests from CL 2699073003

These tests exercise the static and dynamic semantics of `void` used in
those new locations where 'generalized void' added support form it.

They came from CL 2699073003 and were adjusted to match the result of
discussions taken after their creation (in particular, `b ? e1 : e2`
was used and expected to be allowed, but it is now a static warning in
Dart 1.x and a compile-time error in Dart 2).

The tests are located in tests/language_2, and they are testing Dart 2
behavior. In particular, usage of a value of static type `void` is a
compile-time error rather than a static warning, and `void` is
considered equivalent to `Object` in subtype checks, both statically
and dynamically.

We do not currently have any tools which will conform to the
expectations of these tests. Status files have been adjested
accordingly.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/811ae1855d747a6a4c1b83b2027cd862a0ba870e
==========

[eernst, 2017-08-25 08:03:29]

Committed patchset #4 (id:60001) manually as
811ae1855d747a6a4c1b83b2027cd862a0ba870e (presubmit successful).