Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2997283003: Migrated test lock 217 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 3 months ago
Reviewers:
CC:
reviews_dartlang.org, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test lock 217 to Dart 2.0. Fairly simple block, with only minor changes made to lib_2/mirrors tests needed for strong mode compliance. BUG= Committed: https://github.com/dart-lang/sdk/commit/adfc7a6b723ee9e3b2841427650fdcce1f210662

Patch Set 1 #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1642 lines) Patch
M tests/lib/lib.status View 1 3 chunks +0 lines, -7 lines 0 comments Download
D tests/lib/math/rectangle_test.dart View 1 chunk +0 lines, -287 lines 0 comments Download
D tests/lib/mirrors/abstract_class_test.dart View 1 chunk +0 lines, -180 lines 0 comments Download
D tests/lib/mirrors/abstract_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/lib/mirrors/accessor_cache_overflow_test.dart View 1 chunk +0 lines, -309 lines 0 comments Download
D tests/lib/mirrors/array_tracing2_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M tests/lib_2/lib_2.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/lib_2/lib_2_dart2js.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_kernel.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib_2/lib_2_vm.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tests/lib_2/math/rectangle_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/abstract_class_test.dart View 1 2 chunks +0 lines, -5 lines 0 comments Download
A + tests/lib_2/mirrors/abstract_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/accessor_cache_overflow_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/mirrors/array_tracing2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 1 2 chunks +0 lines, -3 lines 0 comments Download
D tests/lib_strong/math/rectangle_test.dart View 1 chunk +0 lines, -288 lines 0 comments Download
D tests/lib_strong/mirrors/abstract_class_test.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D tests/lib_strong/mirrors/abstract_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib_strong/mirrors/accessor_cache_overflow_test.dart View 1 chunk +0 lines, -308 lines 0 comments Download
D tests/lib_strong/mirrors/array_tracing2_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bkonyi
3 years, 3 months ago (2017-08-31 14:47:43 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
adfc7a6b723ee9e3b2841427650fdcce1f210662.

Powered by Google App Engine
This is Rietveld 408576698