Move all the isolate reload code under !defined(DART_PRECOMPILED_RUNTIME)

runtime/vm/runtime_entry.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/runtime_entry.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
@@ skipping 1601 matching lines @@
   // time.
   if (IsCalleeFrameOf(thread->saved_stack_limit(), stack_pos)) {
     // Use the preallocated stack overflow exception to avoid calling
     // into dart code.
     const Instance& exception =
         Instance::Handle(isolate->object_store()->stack_overflow());
     Exceptions::Throw(thread, exception);
     UNREACHABLE();
   }
 
 #if !defined(PRODUCT)

[zra, 2017/08/19 02:28:58]

Is any of this possible in the precompiled runtime?

[siva, 2017/08/23 20:54:51]

They are not used, changed this to
#if !defined(PRODUCT) && !defined(PRECOMPILED_RUNTIME)

   // The following code is used to stress test deoptimization and
   // debugger stack tracing.
   bool do_deopt = false;
   bool do_stacktrace = false;
   bool do_reload = false;
   const intptr_t isolate_reload_every =
       isolate->reload_every_n_stack_overflow_checks();
   if ((FLAG_deoptimize_every > 0) || (FLAG_stacktrace_every > 0) ||
       (isolate_reload_every > 0)) {
     // TODO(turnidge): To make --deoptimize_every and
@@ skipping 36 matching lines @@
         strstr(function_name, FLAG_stacktrace_filter) != NULL) {
       OS::PrintErr("*** Computing stacktrace (%s)\n",
                    function.ToFullyQualifiedCString());
       do_stacktrace = true;
     }
   }
   if (do_deopt) {
     // TODO(turnidge): Consider using DeoptimizeAt instead.
     DeoptimizeFunctionsOnStack();
   }
+#if !defined(DART_PRECOMPILED_RUNTIME)
   if (do_reload) {
     JSONStream js;
     // Maybe adjust the rate of future reloads.
     isolate->MaybeIncreaseReloadEveryNStackOverflowChecks();
     // Issue a reload.
     bool success = isolate->ReloadSources(&js, true /* force_reload */);
     if (!success) {
       FATAL1("*** Isolate reload failed:\n%s\n", js.ToCString());
     }
   }
+#endif  // !defined(DART_PRECOMPILED_RUNTIME)
   if (do_stacktrace) {
     String& var_name = String::Handle();
     Instance& var_value = Instance::Handle();
     // Collecting the stack trace and accessing local variables
     // of frames may trigger parsing of functions to compute
     // variable descriptors of functions. Parsing may trigger
     // code execution, e.g. to compute compile-time constants. Thus,
     // disable FLAG_stacktrace_every during trace collection to prevent
     // recursive stack trace collection.
     intptr_t saved_stacktrace_every = FLAG_stacktrace_every;
@@ skipping 662 matching lines @@
     true /* is_float */,
     reinterpret_cast<RuntimeFunction>(static_cast<UnaryMathCFunction>(&tan)));
 
 DEFINE_RAW_LEAF_RUNTIME_ENTRY(
     LibcAtan,
     1,
     true /* is_float */,
     reinterpret_cast<RuntimeFunction>(static_cast<UnaryMathCFunction>(&atan)));
 
 }  // namespace dart