chrome/browser/search/suggestions/proto/suggestions.proto - Issue 299713007: [Suggestions] Adding a Thumbnail Manager for the Suggestions Service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/suggestions/proto/suggestions.proto

Issue 299713007: [Suggestions] Adding a Thumbnail Manager for the Suggestions Service (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search/suggestions/proto/suggestions.proto

diff --git a/chrome/browser/search/suggestions/proto/suggestions.proto b/chrome/browser/search/suggestions/proto/suggestions.proto

index 77a077c888b8c98a8b6ab30e59f08b7741bcef35..30b0aa42d60536b83cec96b3552b679852495953 100644

--- a/chrome/browser/search/suggestions/proto/suggestions.proto

+++ b/chrome/browser/search/suggestions/proto/suggestions.proto

@@ -25,4 +25,10 @@ message ChromeSuggestion {

// Title of the suggestion.

optional string title = 2;

+ // The URL of the favicon associated with this page.

+ optional string favicon_url = 3;

+ // Specification for the thumbnail to be used.

huangs 2014/05/22 18:08:22 Is thumbnail an URL? Please state if so, else ment

Mathieu 2014/05/22 19:46:32 Done.

+ optional string thumbnail = 4;

}