Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2997103002: [infra] Remove dependence on //third_party/gyp/pylib/gyp/mac_tool.py (Closed)

Created:
3 years, 4 months ago by zra
Modified:
3 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[infra] Remove dependence on //third_party/gyp/pylib/gyp/mac_tool.py This is a step toward removing //third_party/gyp R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3e16939be7ddcd5131bda5b3350d844ecc8b26a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -37 lines) Patch
M build/toolchain/mac/BUILD.gn View 5 chunks +8 lines, -8 lines 0 comments Download
D build/toolchain/mac/setup_toolchain.py View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 4 months ago (2017-08-16 22:42:29 UTC) #2
rmacnak
lgtm
3 years, 4 months ago (2017-08-17 19:30:28 UTC) #3
zra
3 years, 4 months ago (2017-08-17 19:53:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e16939be7ddcd5131bda5b3350d844ecc8b26a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698