Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2997093002: Fix message about status entries that need manual splitting. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
mkroghj, bkonyi
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix message about status entries that need manual splitting. It described the entry as being in the destination file when it's actually still in the source file. R=mkroghj@google.com Committed: https://github.com/dart-lang/sdk/commit/f9da770441c1cad4cc0afb4c0700f222fba0ae55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M tools/migration/lib/src/migrate_statuses.dart View 4 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 4 months ago (2017-08-16 21:56:10 UTC) #2
mkroghj
lgtm
3 years, 4 months ago (2017-08-17 06:54:56 UTC) #3
Bob Nystrom
3 years, 4 months ago (2017-08-17 20:05:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9da770441c1cad4cc0afb4c0700f222fba0ae55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698