[VM mirrors and reified generic functions] Mirrors do not (and will probably

[VM mirrors and reified generic functions] Mirrors do not (and will probably
never) support reification of generic functions. However, instead of crashing
with an UNIMPLEMENTED, reify function type parameters to dynamic.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/1829af87e9328dab203ed0a95c25ae6ae1bc59ae

[regis, 2017-08-16 21:20:18]

regis@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-08-16 21:49:34]

On 2017/08/16 21:20:19, regis wrote:

LGTM

Can you add

// VMOptions=                                                                   
                                  
// VMOptions=--reify-generic-functions  

To tests/lib/mirrors/mirrors_reader_test.dart ?

[regis, 2017-08-16 21:54:58]

On 2017/08/16 21:49:34, rmacnak wrote:
> On 2017/08/16 21:20:19, regis wrote:
> 
> LGTM
> 
> Can you add
> 
> // VMOptions=                                                                 
 
>                                   
> // VMOptions=--reify-generic-functions  
> 
> To tests/lib/mirrors/mirrors_reader_test.dart ?

Thanks!

I cannot add --reify-generic-functions before this cl gets committed:
https://codereview.chromium.org/2893893002/

However, the mirrors tests pass if I patch that cl locally.

I will not commit before tomorrow, because I am about to shutdown for the office
move overnight and would not be able to (easily) revert in case of a major
problem.

[regis, 2017-08-17 18:11:10]

Description was changed from

==========
[VM mirrors and reified generic functions] Mirrors do not (and will probably
never) support reification of generic functions. However, instead of crashing
with an UNIMPLEMENTED, reify function type parameters to dynamic.
==========

to

==========
[VM mirrors and reified generic functions] Mirrors do not (and will probably
never) support reification of generic functions. However, instead of crashing
with an UNIMPLEMENTED, reify function type parameters to dynamic.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1829af87e9328dab203ed0a95c25ae6ae1bc59ae
==========

[regis, 2017-08-17 18:11:11]

Committed patchset #1 (id:1) manually as
1829af87e9328dab203ed0a95c25ae6ae1bc59ae (presubmit successful).