Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: tools/gardening/test/buildbot_data_test.dart

Issue 2997043002: Include build revision in BuildResult (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/lib/src/buildbot_structures.dart ('k') | tools/gardening/test/test_client.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/test/buildbot_data_test.dart
diff --git a/tools/gardening/test/buildbot_data_test.dart b/tools/gardening/test/buildbot_data_test.dart
index 7141683f508afa03d7f8e409f6829550953a52cd..5a76a7eae273b48cca2ec31ac1c3a5b0102a0e9b 100644
--- a/tools/gardening/test/buildbot_data_test.dart
+++ b/tools/gardening/test/buildbot_data_test.dart
@@ -20,6 +20,7 @@ main(List<String> args) async {
Bot bot = new Bot(logdog: useLogdog);
List<String> failingUris = <String>[];
+ List<String> missingBuildNumbers = <String>[];
List<BuildUri> buildUris = <BuildUri>[];
for (BuildGroup buildGroup in buildGroups) {
for (BuildSubgroup buildSubgroup in buildGroup.subgroups) {
@@ -33,6 +34,11 @@ main(List<String> args) async {
BuildResult result = buildResults[index];
if (result == null) {
failingUris.add('$buildUri');
+ } else {
+ if (result.buildNumber == null) {
+ missingBuildNumbers.add('$buildUri');
+ }
+ Expect.isNotNull(result.buildRevision, "No build revision in $buildUri");
}
}
// TODO(johnniwinther): Find out why these steps cannot be read.
@@ -46,5 +52,11 @@ main(List<String> args) async {
], failingUris,
"Unexpected failing buildbot uris:\n ${failingUris.join('\n ')}");
+ Expect.setEquals(
+ [],
+ missingBuildNumbers,
+ "Unexpected missing build numbers in:\n "
+ "${missingBuildNumbers.join('\n ')}");
+
bot.close();
}
« no previous file with comments | « tools/gardening/lib/src/buildbot_structures.dart ('k') | tools/gardening/test/test_client.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698