Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 299703018: Revert of Fix and re-enable some browser focus interactive ui tests. (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, Jay Civelli, Finnur, Ilya Sherman, Paweł Hajdan Jr., rvargas (doing something else), ckocagil, Elliot Glaysher, pkotwicz
Visibility:
Public.

Description

Revert of Fix and re-enable some browser focus interactive ui tests. (https://codereview.chromium.org/296523002/) Reason for revert: Tests failing on WinXP waterfall bot: 2 tests timed out: BrowserFocusTest.FocusTraversal BrowserFocusTest.FocusTraversalOnInterstitial Starting http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31296 Original issue's description: > Fix and re-enable some browser focus interactive ui tests. > > Fix FocusTraversal[OnInterstitial] except *OnInterstitial on Mac :( > Fix InterstitialFocus and FindFocusTest. > > Add a TestFocusTraversal helper function consolidated from tests. > Simplify TestInterstitialPage and add a WaitForInterstitial helper. > Move test server init to a common SetUpOnMainThread. > Remove unnecessary helpers and includes. > > TODO(followup): Fix more tests! > TODO(followup): s/DisableFindBarAnimationsDuringTesting/ScopedAnimationDurationScaleMode/? > > BUG=60973, 62544, 67301, 81451, 109770, 163931 > TEST=Automated tests work and stay enabled... > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272259 TBR=sky@chromium.org,msw@chromium.org NOTREECHECKS=true NOTRY=true BUG=60973, 62544, 67301, 81451, 109770, 163931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -185 lines) Patch
M chrome/browser/ui/browser_focus_uitest.cc View 21 chunks +473 lines, -185 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tapted
Created Revert of Fix and re-enable some browser focus interactive ui tests.
6 years, 7 months ago (2014-05-23 06:12:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/299703018/1
6 years, 7 months ago (2014-05-23 06:14:01 UTC) #2
commit-bot: I haz the power
Change committed as 272410
6 years, 7 months ago (2014-05-23 06:16:19 UTC) #3
msw
6 years, 7 months ago (2014-05-23 16:30:46 UTC) #4
Message was sent while issue was closed.
lgtm; darn XP!

Powered by Google App Engine
This is Rietveld 408576698