Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: chrome/browser/about_flags.cc

Issue 299703016: Gate disabling nacl code on proper gyp flags, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix guard on flags code Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/filename_rules.gypi ('k') | components/nacl/loader/nacl_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index f4368dfe53b5c46ef6090661ffca6d5f669bb1c9..6c77ba365dba282ba9033cca4e05ff4182933d75 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -176,6 +176,7 @@ const Experiment::Choice kOverscrollHistoryNavigationChoices[] = {
};
#endif
+#if !defined(DISABLE_NACL)
const Experiment::Choice kNaClDebugMaskChoices[] = {
// Secure shell can be used on ChromeOS for forwarding the TCP port opened by
// debug stub to a remote machine. Since secure shell uses NaCl, we usually
@@ -188,6 +189,7 @@ const Experiment::Choice kNaClDebugMaskChoices[] = {
{ IDS_NACL_DEBUG_MASK_CHOICE_INCLUDE_DEBUG,
switches::kNaClDebugMask, "*://*/*debug.nmf" }
};
+#endif
const Experiment::Choice kImplSidePaintingChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
@@ -589,12 +591,13 @@ const Experiment kExperiments[] = {
kOsAll,
MULTI_VALUE_TYPE(kEnableAcceleratedFixedRootBackgroundChoices)
},
- // TODO(bbudge): When NaCl is on by default, remove this flag entry.
+ // Native client is compiled out when DISABLE_NACL is defined.
+#if !defined(DISABLE_NACL)
{
"enable-nacl", // FLAGS:RECORD_UMA
IDS_FLAGS_ENABLE_NACL_NAME,
IDS_FLAGS_ENABLE_NACL_DESCRIPTION,
- kOsDesktop,
+ kOsAll,
SINGLE_VALUE_TYPE(switches::kEnableNaCl)
},
{
@@ -618,6 +621,7 @@ const Experiment kExperiments[] = {
kOsDesktop,
MULTI_VALUE_TYPE(kNaClDebugMaskChoices)
},
+#endif
{
"extension-apis", // FLAGS:RECORD_UMA
IDS_FLAGS_EXPERIMENTAL_EXTENSION_APIS_NAME,
@@ -895,6 +899,8 @@ const Experiment kExperiments[] = {
kOsDesktop,
SINGLE_VALUE_TYPE(switches::kEnableDownloadResumption)
},
+ // Native client is compiled out when DISABLE_NACL is defined.
+#if !defined(DISABLE_NACL)
{
"allow-nacl-socket-api",
IDS_FLAGS_ALLOW_NACL_SOCKET_API_NAME,
@@ -902,6 +908,7 @@ const Experiment kExperiments[] = {
kOsDesktop,
SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*")
},
+#endif
{
"force-device-scale-factor",
IDS_FLAGS_FORCE_HIGH_DPI_NAME,
« no previous file with comments | « build/filename_rules.gypi ('k') | components/nacl/loader/nacl_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698