Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 299703016: Gate disabling nacl code on proper gyp flags, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove speculative changes from review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 kOsAll, 582 kOsAll,
583 MULTI_VALUE_TYPE(kEnableCompositingForTransitionChoices) 583 MULTI_VALUE_TYPE(kEnableCompositingForTransitionChoices)
584 }, 584 },
585 { 585 {
586 "enable-accelerated-fixed-root-background", 586 "enable-accelerated-fixed-root-background",
587 IDS_FLAGS_ACCELERATED_FIXED_ROOT_BACKGROUND_NAME, 587 IDS_FLAGS_ACCELERATED_FIXED_ROOT_BACKGROUND_NAME,
588 IDS_FLAGS_ACCELERATED_FIXED_ROOT_BACKGROUND_DESCRIPTION, 588 IDS_FLAGS_ACCELERATED_FIXED_ROOT_BACKGROUND_DESCRIPTION,
589 kOsAll, 589 kOsAll,
590 MULTI_VALUE_TYPE(kEnableAcceleratedFixedRootBackgroundChoices) 590 MULTI_VALUE_TYPE(kEnableAcceleratedFixedRootBackgroundChoices)
591 }, 591 },
592 // TODO(bbudge): When NaCl is on by default, remove this flag entry. 592 // Native client is compiled out when DISABLE_NACL is defined.
593 #if !defined(DISABLE_NACL)
593 { 594 {
594 "enable-nacl", // FLAGS:RECORD_UMA 595 "enable-nacl", // FLAGS:RECORD_UMA
595 IDS_FLAGS_ENABLE_NACL_NAME, 596 IDS_FLAGS_ENABLE_NACL_NAME,
596 IDS_FLAGS_ENABLE_NACL_DESCRIPTION, 597 IDS_FLAGS_ENABLE_NACL_DESCRIPTION,
597 kOsDesktop, 598 kOsAll,
598 SINGLE_VALUE_TYPE(switches::kEnableNaCl) 599 SINGLE_VALUE_TYPE(switches::kEnableNaCl)
599 }, 600 },
600 { 601 {
601 "enable-nacl-debug", // FLAGS:RECORD_UMA 602 "enable-nacl-debug", // FLAGS:RECORD_UMA
602 IDS_FLAGS_ENABLE_NACL_DEBUG_NAME, 603 IDS_FLAGS_ENABLE_NACL_DEBUG_NAME,
603 IDS_FLAGS_ENABLE_NACL_DEBUG_DESCRIPTION, 604 IDS_FLAGS_ENABLE_NACL_DEBUG_DESCRIPTION,
604 kOsDesktop, 605 kOsDesktop,
605 SINGLE_VALUE_TYPE(switches::kEnableNaClDebug) 606 SINGLE_VALUE_TYPE(switches::kEnableNaClDebug)
606 }, 607 },
607 { 608 {
608 "disable-pnacl", // FLAGS:RECORD_UMA 609 "disable-pnacl", // FLAGS:RECORD_UMA
609 IDS_FLAGS_DISABLE_PNACL_NAME, 610 IDS_FLAGS_DISABLE_PNACL_NAME,
610 IDS_FLAGS_DISABLE_PNACL_DESCRIPTION, 611 IDS_FLAGS_DISABLE_PNACL_DESCRIPTION,
611 kOsDesktop, 612 kOsDesktop,
612 SINGLE_VALUE_TYPE(switches::kDisablePnacl) 613 SINGLE_VALUE_TYPE(switches::kDisablePnacl)
613 }, 614 },
614 { 615 {
615 "nacl-debug-mask", // FLAGS:RECORD_UMA 616 "nacl-debug-mask", // FLAGS:RECORD_UMA
616 IDS_FLAGS_NACL_DEBUG_MASK_NAME, 617 IDS_FLAGS_NACL_DEBUG_MASK_NAME,
617 IDS_FLAGS_NACL_DEBUG_MASK_DESCRIPTION, 618 IDS_FLAGS_NACL_DEBUG_MASK_DESCRIPTION,
618 kOsDesktop, 619 kOsDesktop,
619 MULTI_VALUE_TYPE(kNaClDebugMaskChoices) 620 MULTI_VALUE_TYPE(kNaClDebugMaskChoices)
620 }, 621 },
622 #endif
621 { 623 {
622 "extension-apis", // FLAGS:RECORD_UMA 624 "extension-apis", // FLAGS:RECORD_UMA
623 IDS_FLAGS_EXPERIMENTAL_EXTENSION_APIS_NAME, 625 IDS_FLAGS_EXPERIMENTAL_EXTENSION_APIS_NAME,
624 IDS_FLAGS_EXPERIMENTAL_EXTENSION_APIS_DESCRIPTION, 626 IDS_FLAGS_EXPERIMENTAL_EXTENSION_APIS_DESCRIPTION,
625 kOsDesktop, 627 kOsDesktop,
626 SINGLE_VALUE_TYPE(extensions::switches::kEnableExperimentalExtensionApis) 628 SINGLE_VALUE_TYPE(extensions::switches::kEnableExperimentalExtensionApis)
627 }, 629 },
628 { 630 {
629 "extensions-on-chrome-urls", 631 "extensions-on-chrome-urls",
630 IDS_FLAGS_EXTENSIONS_ON_CHROME_URLS_NAME, 632 IDS_FLAGS_EXTENSIONS_ON_CHROME_URLS_NAME,
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
888 chromeos::switches::kDisableNetworkPortalNotification) 890 chromeos::switches::kDisableNetworkPortalNotification)
889 }, 891 },
890 #endif 892 #endif
891 { 893 {
892 "enable-download-resumption", 894 "enable-download-resumption",
893 IDS_FLAGS_ENABLE_DOWNLOAD_RESUMPTION_NAME, 895 IDS_FLAGS_ENABLE_DOWNLOAD_RESUMPTION_NAME,
894 IDS_FLAGS_ENABLE_DOWNLOAD_RESUMPTION_DESCRIPTION, 896 IDS_FLAGS_ENABLE_DOWNLOAD_RESUMPTION_DESCRIPTION,
895 kOsDesktop, 897 kOsDesktop,
896 SINGLE_VALUE_TYPE(switches::kEnableDownloadResumption) 898 SINGLE_VALUE_TYPE(switches::kEnableDownloadResumption)
897 }, 899 },
900 // Native client is compiled out when DISABLE_NACL is defined.
901 #if !defined(DISABLE_NACL)
898 { 902 {
899 "allow-nacl-socket-api", 903 "allow-nacl-socket-api",
900 IDS_FLAGS_ALLOW_NACL_SOCKET_API_NAME, 904 IDS_FLAGS_ALLOW_NACL_SOCKET_API_NAME,
901 IDS_FLAGS_ALLOW_NACL_SOCKET_API_DESCRIPTION, 905 IDS_FLAGS_ALLOW_NACL_SOCKET_API_DESCRIPTION,
902 kOsDesktop, 906 kOsDesktop,
903 SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*") 907 SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*")
904 }, 908 },
909 #endif
905 { 910 {
906 "force-device-scale-factor", 911 "force-device-scale-factor",
907 IDS_FLAGS_FORCE_HIGH_DPI_NAME, 912 IDS_FLAGS_FORCE_HIGH_DPI_NAME,
908 IDS_FLAGS_FORCE_HIGH_DPI_DESCRIPTION, 913 IDS_FLAGS_FORCE_HIGH_DPI_DESCRIPTION,
909 kOsCrOS, 914 kOsCrOS,
910 SINGLE_VALUE_TYPE_AND_VALUE(switches::kForceDeviceScaleFactor, "2") 915 SINGLE_VALUE_TYPE_AND_VALUE(switches::kForceDeviceScaleFactor, "2")
911 }, 916 },
912 #if defined(OS_CHROMEOS) 917 #if defined(OS_CHROMEOS)
913 { 918 {
914 "allow-touchpad-three-finger-click", 919 "allow-touchpad-three-finger-click",
(...skipping 1433 matching lines...) Expand 10 before | Expand all | Expand 10 after
2348 } 2353 }
2349 2354
2350 const Experiment* GetExperiments(size_t* count) { 2355 const Experiment* GetExperiments(size_t* count) {
2351 *count = num_experiments; 2356 *count = num_experiments;
2352 return experiments; 2357 return experiments;
2353 } 2358 }
2354 2359
2355 } // namespace testing 2360 } // namespace testing
2356 2361
2357 } // namespace about_flags 2362 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698