Settings: adjust history before changing the title in changePageTo.

Settings: adjust history before changing the title in changePageTo.

Otherwise the title change applies to the previous navigation entry and causes
trouble.

BUG=376034
TEST=Open settings. Click History, Extensions, Settings, History, Extensions,
    Settings, etc. Drag the back button down. Icons should match titles (and
    the pages the entries should be on).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272289

[Dan Beam, 2014-05-22 00:46:43]

lgtm

https://codereview.chromium.org/299703012/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/299703012/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:347: changePathTo(pageId, {}, path,
historyOption);
nit: \n

[davidben, 2014-05-22 01:00:14]

https://codereview.chromium.org/299703012/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/299703012/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:347: changePathTo(pageId, {}, path,
historyOption);
On 2014/05/22 00:46:43, Dan Beam wrote:
> nit: \n

Done.

[davidben, 2014-05-22 01:00:17]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-22 01:02:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/299703012/20001

[commit-bot: I haz the power, 2014-05-22 11:05:26]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 11:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 11:07:57]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Dan Beam, 2014-05-22 16:30:29]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:30:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/299703012/20001

[commit-bot: I haz the power, 2014-05-22 16:34:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 16:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:37:41]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[davidben, 2014-05-22 17:31:10]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-22 17:34:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/299703012/20001

[commit-bot: I haz the power, 2014-05-22 19:57:48]

Change committed as 272289