Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 299703004: Use SameValueZero for Map and Set (Closed)

Created:
6 years, 7 months ago by arv (Not doing code reviews)
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use SameValueZero for Map and Set Instead of normalizing the keys we use SameValueZero for the actual comparison. BUG=v8:1622 LOG=Y R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -28 lines) Patch
M src/collection.js View 8 chunks +6 lines, -26 lines 0 comments Download
M src/objects.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
6 years, 7 months ago (2014-05-20 21:03:30 UTC) #1
Michael Starzinger
LGTM.
6 years, 7 months ago (2014-05-21 08:34:50 UTC) #2
adamk
6 years, 7 months ago (2014-05-21 08:47:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698