Issue 299703002: Decouple RVH creation from CrossProcessFrameConnector.

Issue 299703002: Decouple RVH creation from CrossProcessFrameConnector. (Closed)

Created:
6 years, 7 months ago by nasko

Modified:
6 years, 7 months ago

Reviewers:
kenrb, jam

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Decouple RVH creation from CrossProcessFrameConnector. This is a reland of https://codereview.chromium.org/270883003/, which was reverted because it missed to update one of the callers to CreateRenderViewForRenderManager. Patchset 1 is the equivalent to the previous commit. BUG=357747 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272078

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -32 lines)			Patch
M	content/browser/frame_host/cross_process_frame_connector.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/frame_host/cross_process_frame_connector.cc	View		3 chunks	+24 lines, -15 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_manager.h	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_manager.cc	View		9 chunks	+27 lines, -7 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	content/test/test_web_contents.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/test/test_web_contents.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

nasko

Ken, Can you review this CL for me? The first patchset is equivalent to the ...

6 years, 7 months ago (2014-05-21 05:15:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/299703002/20001

6 years, 7 months ago (2014-05-21 19:58:58 UTC) #5

Message was sent while issue was closed.

Change committed as 272078