Refactor of the GetEmbedderInformation APIs

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 #include "platform/globals.h"
 
@@ skipping 3844 matching lines @@
 
 static const MethodParameter* get_vm_params[] = {
     NO_ISOLATE_PARAMETER, NULL,
 };
 
 void Service::PrintJSONForEmbedderInformation(JSONObject *jsobj) {
   if (embedder_information_callback_ != NULL) {
     Dart_EmbedderInformation info = {
       0,  // version
       NULL,  // name
-      0,  // max_rss
-      0  // current_rss
+      -1,  // max_rss
+      -1  // current_rss
     };
     embedder_information_callback_(&info);
     ASSERT(info.version == DART_EMBEDDER_INFORMATION_CURRENT_VERSION);
     if (info.name != NULL) {
       jsobj->AddProperty("_embedder", info.name);
     }
-    if (info.max_rss > 0) {
+    if (info.max_rss >= 0) {
       jsobj->AddProperty64("_maxRSS", info.max_rss);
     }
-    if (info.max_rss > 0) {
+    if (info.current_rss >= 0) {
       jsobj->AddProperty64("_currentRSS", info.current_rss);
     }
   }
 }
 
 void Service::PrintJSONForVM(JSONStream* js, bool ref) {
   JSONObject jsobj(js);
   jsobj.AddProperty("type", (ref ? "@VM" : "VM"));
   jsobj.AddProperty("name", GetVMName());
   if (ref) {
@@ skipping 313 matching lines @@
     if (strcmp(method_name, method.name) == 0) {
       return &method;
     }
   }
   return NULL;
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart