content/browser/devtools/embedded_worker_devtools_manager_unittest.cc - Issue 299693002: Add option to open the DevTools window for ServiceWorker on start in serviceworker-internals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

Issue 299693002: Add option to open the DevTools window for ServiceWorker on start in serviceworker-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/embedded_worker_devtools_manager.cc ('k') | content/browser/resources/service_worker/serviceworker_internals.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

diff --git a/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc b/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

index 49a6144134d61c40e6030eb66d415f19bfe84eb7..04cb2e10139ec561f15c0cc6f97a9352e9494ad7 100644

--- a/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

+++ b/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

@@ -230,7 +230,8 @@ TEST_F(EmbeddedWorkerDevToolsManagerTest, AttachTest) {

CheckWorkerState(2, 1, EmbeddedWorkerDevToolsManager::WORKER_TERMINATED);

manager_->SharedWorkerCreated(2, 3, instance1);

CheckWorkerNotExist(2, 1);

- CheckWorkerState(2, 3, EmbeddedWorkerDevToolsManager::WORKER_PAUSED);

+ CheckWorkerState(

+ 2, 3, EmbeddedWorkerDevToolsManager::WORKER_PAUSED_FOR_REATTACH);

EXPECT_EQ(agent_host1.get(), manager_->GetDevToolsAgentHostForWorker(2, 3));

manager_->WorkerContextStarted(2, 3);

CheckWorkerState(2, 3, EmbeddedWorkerDevToolsManager::WORKER_INSPECTED);

@@ -243,7 +244,8 @@ TEST_F(EmbeddedWorkerDevToolsManagerTest, AttachTest) {

CheckWorkerState(2, 2, EmbeddedWorkerDevToolsManager::WORKER_TERMINATED);

manager_->SharedWorkerCreated(2, 4, instance2);

CheckWorkerNotExist(2, 2);

- CheckWorkerState(2, 4, EmbeddedWorkerDevToolsManager::WORKER_PAUSED);

+ CheckWorkerState(

+ 2, 4, EmbeddedWorkerDevToolsManager::WORKER_PAUSED_FOR_REATTACH);

EXPECT_EQ(agent_host2.get(), manager_->GetDevToolsAgentHostForWorker(2, 4));

manager_->WorkerDestroyed(2, 4);

CheckWorkerNotExist(2, 4);

@@ -252,7 +254,8 @@ TEST_F(EmbeddedWorkerDevToolsManagerTest, AttachTest) {

// Re-created -> ClientHostClosing -> Destroyed

manager_->SharedWorkerCreated(2, 5, instance2);

CheckWorkerNotExist(2, 2);

- CheckWorkerState(2, 5, EmbeddedWorkerDevToolsManager::WORKER_PAUSED);

+ CheckWorkerState(

+ 2, 5, EmbeddedWorkerDevToolsManager::WORKER_PAUSED_FOR_REATTACH);

EXPECT_EQ(agent_host2.get(), manager_->GetDevToolsAgentHostForWorker(2, 5));

ClientHostClosing(client_host2.get());

CheckWorkerCount(1);