Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4880)

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 299693002: Add option to open the DevTools window for ServiceWorker on start in serviceworker-internals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_internals_ui.cc
diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc
index f69132f0fb8dbd913294803ec91eae6da4db803b..9c4284c8c01cb611f2ce26192702e31e927ddd2d 100644
--- a/content/browser/service_worker/service_worker_internals_ui.cc
+++ b/content/browser/service_worker/service_worker_internals_ui.cc
@@ -204,6 +204,13 @@ ServiceWorkerInternalsUI::ServiceWorkerInternalsUI(WebUI* web_ui)
WebUIDataSource::Add(browser_context, source);
web_ui->RegisterMessageCallback(
+ "GetOptions",
+ base::Bind(&ServiceWorkerInternalsUI::GetOptions,
+ base::Unretained(this)));
+ web_ui->RegisterMessageCallback(
+ "SetOption",
+ base::Bind(&ServiceWorkerInternalsUI::SetOption, base::Unretained(this)));
+ web_ui->RegisterMessageCallback(
"getAllRegistrations",
base::Bind(&ServiceWorkerInternalsUI::GetAllRegistrations,
base::Unretained(this)));
@@ -240,6 +247,26 @@ ServiceWorkerInternalsUI::~ServiceWorkerInternalsUI() {
BrowserContext::ForEachStoragePartition(browser_context, remove_observer_cb);
}
+void ServiceWorkerInternalsUI::GetOptions(const ListValue* args) {
+ DictionaryValue options;
+ options.SetBoolean("debug_on_start",
+ EmbeddedWorkerDevToolsManager::GetInstance()
+ ->debug_service_worker_on_start());
+ web_ui()->CallJavascriptFunction("serviceworker.onOptions", options);
+}
+
+void ServiceWorkerInternalsUI::SetOption(const ListValue* args) {
+ std::string option_name;
+ bool option_boolean;
+ if (!args->GetString(0, &option_name)||
+ option_name != "debug_on_start" ||
+ !args->GetBoolean(1, &option_boolean)) {
+ return;
+ }
+ EmbeddedWorkerDevToolsManager::GetInstance()
+ ->set_debug_service_worker_on_start(option_boolean);
+}
+
void ServiceWorkerInternalsUI::GetAllRegistrations(const ListValue* args) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

Powered by Google App Engine
This is Rietveld 408576698