Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart

Issue 2996843002: Add IncrementalKernelGenerator.acceptLastDelta()/rejectLastDelta(). (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart
diff --git a/pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart b/pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart
index 76dae64380ebbb06830924c567061f274a5bdb65..3c05b0d9668ff36514e24cbe6747ecade5524741 100644
--- a/pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart
+++ b/pkg/front_end/test/src/incremental/hot_reload_e2e_test.dart
@@ -187,6 +187,7 @@ Future<bool> rebuild(IncrementalKernelGenerator compiler, Uri outputUri) async {
compiler.invalidate(Uri.parse("file:///a.dart"));
compiler.invalidate(Uri.parse("file:///b.dart"));
var program = (await compiler.computeDelta()).newProgram;
+ compiler.acceptLastDelta();
Siggi Cherem (dart-lang) 2017/08/10 18:31:15 A couple suggestions: feel free to ignore if you d
scheglov 2017/08/10 19:28:39 I moved this line into hotReload() and setUp(). I
if (program != null && !program.libraries.isEmpty) {
await writeProgram(program, outputUri);
return true;

Powered by Google App Engine
This is Rietveld 408576698