Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 299683002: Remove legacy constructor for blur draw looper. (Closed)

Created:
6 years, 7 months ago by scroggo
Modified:
6 years, 7 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove legacy constructor for blur draw looper. Now that Android no longer uses the constructor, remove it, along with the flag. Committed: http://code.google.com/p/skia/source/detail?r=14797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
6 years, 7 months ago (2014-05-20 13:14:02 UTC) #1
reed1
lgtm when can we eliminate this entire subclass?
6 years, 7 months ago (2014-05-20 13:42:17 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 7 months ago (2014-05-20 14:30:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/299683002/1
6 years, 7 months ago (2014-05-20 14:30:31 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 14:53:41 UTC) #5
Message was sent while issue was closed.
Change committed as 14797

Powered by Google App Engine
This is Rietveld 408576698