Add current rss and embedder name to Observatory

runtime/include/dart_tools_api.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_INCLUDE_DART_TOOLS_API_H_
 #define RUNTIME_INCLUDE_DART_TOOLS_API_H_
 
 #include "dart_api.h"
 
 /** \mainpage Dart Tools Embedding API Reference
@@ skipping 747 matching lines @@
  * \param user_data The user data passed to the callback.
  *
  * NOTE: If multiple callbacks with the same name are registered, only
  * the last callback registered will be remembered.
  */
 DART_EXPORT void Dart_RegisterRootServiceRequestCallback(
     const char* method,
     Dart_ServiceRequestCallback callback,
     void* user_data);
 
+/**
+ * Embedder information which can be requested by the VM for internal or
+ * reporting purposes.
+ *
+ * The pointers in this structure are not going to be cached or freed by the VM.
+ */
+
+typedef struct {

[zra, 2017/08/10 22:19:50]

This should probably have a version field. See for example Dart_InitializeParams
in dart_api.h.

[cbernaschina, 2017/08/12 00:29:42]

Done.

+  const char* name;  // [optional] The name of the embedder
+  uintptr_t current_rss;  // [optional] the current RSS of the embedder
+  uintptr_t max_rss;  // [optional] the maximum RSS of the embedder
+} Dart_EmbedderInformation;
+
+/**
+ * Callback provided by the embedder that is used by the vm to request
+ * information.
+ *
+ * \return Returns a pointer to a Dart_EmbedderInformation structure.
+ * The embedder keeps the ownership of the structure and any field in it.
+ * The embedder must ensure that the structure will remain valid until the
+ * next invokation of the callback.
+ */
+typedef const Dart_EmbedderInformation* (*Dart_GetEmbedderInformation)();

[zra, 2017/08/10 22:19:50]

Maybe Dart_GetEmbedderInformation -> Dart_EmbedderInformationCallback

[cbernaschina, 2017/08/12 00:29:42]

Done.

+
+/**
+ * Register a Dart_ServiceRequestCallback to be called to handle
+ * requests for the named rpc. The callback will be invoked without a
+ * current isolate.
+ *
+ * \param method The name of the command that this callback is responsible for.
+ * \param callback The callback to invoke.
+ * \param user_data The user data passed to the callback.
+ *
+ * NOTE: If multiple callbacks with the same name are registered, only
+ * the last callback registered will be remembered.
+ */
+DART_EXPORT void Dart_SetGetEmbedderInformationCallback(

[zra, 2017/08/09 22:58:27]

Consider a rename to avoid "SetGet", which doesn't read well to me.

[cbernaschina, 2017/08/10 00:29:17]

I called it SetGetEmbedderInformationCallback... following the example of
SetGetServiceAssetsCallback in service.h

I don't like RegisterGetEmbedderInformationCallback because register gives more
an idea of "more than one".

What about SetEmbedderInformationGetter ?

[zra, 2017/08/10 22:19:50]

Maybe just SetEmbedderInformationCallback?

[cbernaschina, 2017/08/12 00:29:42]

Done.

+    Dart_GetEmbedderInformation get_embedder_information);
+
 /*
  * ========
  * Event Streams
  * ========
  */
 
 /**
  * A callback invoked when the VM service gets a request to listen to
  * some stream.
  *
@@ skipping 242 matching lines @@
  * \param start_recording See Dart_EmbedderTimelineStartRecording.
  * \param stop_recording See Dart_EmbedderTimelineStopRecording.
  *
  * NOTE: To avoid races, this should be called before Dart_Initialize.
  */
 DART_EXPORT void Dart_SetEmbedderTimelineCallbacks(
     Dart_EmbedderTimelineStartRecording start_recording,
     Dart_EmbedderTimelineStopRecording stop_recording);
 
 #endif  // RUNTIME_INCLUDE_DART_TOOLS_API_H_